Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 813453002: Oilpan: have PageSerializer accurately handle its GCed references. (Closed)

Created:
6 years ago by sof
Modified:
6 years ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have PageSerializer accurately handle its GCed references. Have the references to GCed objects be appropriately accounted for during GCs over this stack allocated object. R= BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187314

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M Source/core/page/PageSerializer.h View 3 chunks +8 lines, -4 lines 0 comments Download
M Source/core/page/PageSerializer.cpp View 8 chunks +11 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
sof
Please take a look.
6 years ago (2014-12-16 19:50:02 UTC) #2
haraken
LGTM
6 years ago (2014-12-16 23:51:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813453002/1
6 years ago (2014-12-16 23:52:17 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-17 01:03:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187314

Powered by Google App Engine
This is Rietveld 408576698