go/buildbot/db.go - Issue 813443002: Overhaul database package

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/buildbot/db.go

Issue 813443002: Overhaul database package (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Add README for database package, re-add *.db to .gitignore Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: go/buildbot/db.go

diff --git a/go/buildbot/db.go b/go/buildbot/db.go

index 21d4eeff0f97d38563787ae65c817415cc7b9658..c62b7346ce785898cbf2dec31f108862c3f91d56 100644

--- a/go/buildbot/db.go

+++ b/go/buildbot/db.go

@@ -141,9 +141,9 @@ func (b Build) ReplaceIntoDB() (rv error) {

}

defer insertStepStmt.Close()

for _, s := range b.Steps {

- _, err = insertStepStmt.Exec(s.BuilderName, s.MasterName, s.BuildNumber, s.Name, s.Results, s.Number, s.Started, s.Finished)

+ _, err = insertStepStmt.Exec(b.BuilderName, b.MasterName, b.Number, s.Name, s.Results, s.Number, s.Started, s.Finished)

if err != nil {

- return fmt.Errorf("Failed to push build into database: %v", err)

+ return fmt.Errorf("Failed to push build step into database: %v", err)

}