Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Unified Diff: perf/DESIGN.md

Issue 813443002: Overhaul database package (Closed) Base URL: https://skia.googlesource.com/buildbot@master
Patch Set: Assume the MySQL password is "" when running locally Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « golden/go/skiacorrectness/main.go ('k') | perf/go/db/db.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: perf/DESIGN.md
diff --git a/perf/DESIGN.md b/perf/DESIGN.md
index 0b39cb3196e4aa2730d08fbf2483745d323efa92..83b421f8bec01947af2bedf00a4f2b31c9820bc5 100644
--- a/perf/DESIGN.md
+++ b/perf/DESIGN.md
@@ -197,7 +197,7 @@ GCE):
Initial setup of the database, the users, and the tables:
* Create the database and set up permissions. Execute the following after
- you connect to a MySQL database (not necessary for SQLite).
+ you connect to a MySQL database.
CREATE DATABASE skia;
USE skia;
@@ -209,10 +209,9 @@ Initial setup of the database, the users, and the tables:
* Create the versioned database tables.
We use the 'migratedb' tool to keep the database in a well defined (versioned)
- state. The 'db_conn_string' flag allows to specify the target database.
- By default it will try to connect to the production environment.
- But for testing a local MySQL database can be provided. If it cannot
- connect to MySQL it will fall back to SQLite.
+ state. The db_host, db_port, db_user, and db_name flags allow you to specify
+ the target database. By default it will try to connect to the production
+ environment. But for testing a local MySQL database can be provided.
Bring the production database to the latest schema version:
@@ -220,11 +219,7 @@ Initial setup of the database, the users, and the tables:
Bring a local database to the latest schema version:
- $ migratedb -logtostderr=true -db_conn_string="root:%s@tcp(localhost:3306)/skia?parseTime=true"
-
- Bring a local SQLite database to the latest schema version:
-
- $ migratedb -logtostderr=true -db_conn_string=""
+ $ perf_migratedb -logtostderr=true -db_host=localhost --local
Nginx
« no previous file with comments | « golden/go/skiacorrectness/main.go ('k') | perf/go/db/db.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698