go/database/setup_test_db - Issue 813443002: Overhaul database package

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: go/database/setup_test_db

Issue 813443002: Overhaul database package (Closed) Base URL: https://skia.googlesource.com/buildbot@master

Patch Set: Add script for setting up test db Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 #!/bin/bash
	borenet 2014/12/16 20:24:18 Should this run automatically? Should this run automatically? stephana 2014/12/17 13:13:38 IMO it's fine to run it manually, but there needs Show quoted text On 2014/12/16 20:24:18, borenet wrote: > Should this run automatically? IMO it's fine to run it manually, but there needs to be a README somewhere that describes what's necessary to set up the database. If the database doesn't exist the tests should fail and either point to the README file or the script. borenet 2014/12/17 14:55:13 Added a README. I'm not sure how to make the erro Show quoted text On 2014/12/17 13:13:38, stephana wrote: > On 2014/12/16 20:24:18, borenet wrote: > > Should this run automatically? > > IMO it's fine to run it manually, but there needs to be a README somewhere that > describes what's necessary to set up the database. > > If the database doesn't exist the tests should fail and either point to the > README file or the script. Added a README. I'm not sure how to make the error message point back to the script, since the error would be encountered somewhere down the line when someone runs sql.Open. AFAICT there's not an easy way to inject the message at that point.
	2 # Set up the test database and user.

	3

	4 mysql -u root -p < setup_test_db.sql

OLD	NEW

« no previous file with comments | « go/database/database.go ('k') | go/database/setup_test_db.sql » ('j') | no next file with comments »