Overhaul database package

go/database/testutil/testutil.go

 package testutil
 
 import (
         "fmt"
         "os"
         "strings"
         "testing"
 )
 
 import (
         // Using 'require' which is like using 'assert' but causes tests to fail.
         assert "github.com/stretchr/testify/require"
 
         "skia.googlesource.com/buildbot.git/go/database"
 )
 
 // Connection string to the local MySQL database for testing.
 const (
         // String to open a local database for testing. The string formatting
         // parameters are: username, password, database.
         MYSQL_DB_OPEN = "%s:%s@tcp(localhost:3306)/%s?parseTime=true"
 
-        // File path to the local SQLite testing databse.
-        SQLITE_DB_PATH = "./testing.db"
-
         // Name of the MySQL lock
         SQL_LOCK = "mysql_testlock"
 )
 
-// Creates an SQLite test database and runs migration tests against it using the
-// given migration steps.
-func SQLiteVersioningTests(t *testing.T, migrationSteps []database.MigrationStep) {
-        // Initialize without argument to test against SQLite3
-        conf := &database.DatabaseConfig{
-                SQLiteFilePath: SQLITE_DB_PATH,
-                MigrationSteps: migrationSteps,
-        }
-
-        vdb := database.NewVersionedDB(conf)
-        assert.False(t, vdb.IsMySQL)
-        testDBVersioning(t, vdb)
-}
-
 // Creates an MySQL test database and runs migration tests against it using the
 // given migration steps. See Get for required credentials.
 // The test assumes that the database is empty and that the readwrite user is
 // not allowed to create/drop/alter tables.
 func MySQLVersioningTests(t *testing.T, dbName string, migrationSteps []database.MigrationStep) {
         // OpenDB as root user and remove all tables.
         rootConf := &database.DatabaseConfig{
                 MySQLString:    GetTestMySQLConnStr(t, "root", dbName),
                 MigrationSteps: migrationSteps,
         }
         lockVdb := GetMySQlLock(t, rootConf)
         defer func() {
                 ReleaseMySQLLock(t, lockVdb)
                 lockVdb.Close()
         }()
 
         rootVdb := database.NewVersionedDB(rootConf)
-        assert.True(t, rootVdb.IsMySQL)
         ClearMySQLTables(t, rootVdb)
         assert.Nil(t, rootVdb.Close())
 
         // Configuration for the readwrite user without DDL privileges.
         readWriteConf := &database.DatabaseConfig{
                 MySQLString:    GetTestMySQLConnStr(t, "readwrite", dbName),
                 MigrationSteps: migrationSteps,
         }
 
         // Open DB as readwrite user and make sure it fails because of a missing
@@ skipping 83 matching lines @@
         assert.Nil(t, err)
         assert.Equal(t, 0, dbVersion)
 
         // upgrade the the latest version
         err = vdb.Migrate(maxVersion)
         assert.Nil(t, err)
         dbVersion, err = vdb.DBVersion()
         assert.Nil(t, err)
         assert.Equal(t, maxVersion, dbVersion)
 }