Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1124)

Issue 813403005: [fsp] Fix unhappy MSAN build bots. (Closed)

Created:
5 years, 11 months ago by mtomasz
Modified:
5 years, 11 months ago
Reviewers:
yawano
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[fsp] Fix unhappy MSAN build bots. Before, an uninitialized class was being used in queue.h, which is illegal, but for some strange reason fails on MSAN build bots only. TEST=Compiles on MSAN. BUG=None Committed: https://crrev.com/bf1854ac23df80382fbcd9a0e4addbdb19ebe83f Cr-Commit-Position: refs/heads/master@{#310741}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -11 lines) Patch
M chrome/browser/chromeos/file_system_provider/queue.h View 1 chunk +11 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/queue.cc View 1 chunk +9 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
mtomasz
@yawano: PTAL. Thanks.
5 years, 11 months ago (2015-01-09 07:55:27 UTC) #2
yawano
lgtm. Thank you!
5 years, 11 months ago (2015-01-09 08:07:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813403005/1
5 years, 11 months ago (2015-01-09 08:09:32 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-09 08:39:15 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-09 08:39:55 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bf1854ac23df80382fbcd9a0e4addbdb19ebe83f
Cr-Commit-Position: refs/heads/master@{#310741}

Powered by Google App Engine
This is Rietveld 408576698