Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Unified Diff: content/content_unittests.isolate

Issue 813363003: Use Xvfb in isolated testing only if use_x11 is set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/content_unittests.isolate
diff --git a/content/content_unittests.isolate b/content/content_unittests.isolate
index bc982e2c3dd9239f34ab680f63ffd9ee6528bf8b..4837d6e9b9e1868c5f81e489a532af7bc7a1dd5b 100644
--- a/content/content_unittests.isolate
+++ b/content/content_unittests.isolate
@@ -33,7 +33,7 @@
],
},
}],
- ['OS=="linux"', {
+ ['OS=="linux" and use_x11==1', {
'variables': {
'command': [
'../testing/xvfb.py',
@@ -46,28 +46,20 @@
],
'files': [
'../testing/xvfb.py',
- '<(PRODUCT_DIR)/libffmpegsumo.so',
- '<(PRODUCT_DIR)/libosmesa.so',
+ '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
],
},
}],
- ['OS=="linux" and use_ozone==0', {
+ ['OS=="linux"', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
+ '<(PRODUCT_DIR)/libffmpegsumo.so',
+ '<(PRODUCT_DIR)/libosmesa.so',
],
},
}],
['OS=="mac"', {
'variables': {
- 'command': [
- '../testing/test_env.py',
- '<(PRODUCT_DIR)/content_unittests<(EXECUTABLE_SUFFIX)',
- '--brave-new-test-launcher',
- '--test-launcher-bot-mode',
- '--asan=<(asan)',
- '--lsan=<(lsan)',
- ],
'files': [
'<(PRODUCT_DIR)/ffmpegsumo.so',
'<(PRODUCT_DIR)/osmesa.so',
@@ -76,6 +68,14 @@
}],
['OS=="win"', {
'variables': {
+ 'files': [
+ '<(PRODUCT_DIR)/ffmpegsumo.dll',
+ '<(PRODUCT_DIR)/osmesa.dll',
+ ],
+ },
+ }],
+ ['OS=="win" or OS=="mac" or use_ozone==1', {
+ 'variables': {
'command': [
'../testing/test_env.py',
'<(PRODUCT_DIR)/content_unittests<(EXECUTABLE_SUFFIX)',
@@ -84,10 +84,6 @@
'--asan=<(asan)',
'--lsan=<(lsan)',
],
- 'files': [
- '<(PRODUCT_DIR)/ffmpegsumo.dll',
- '<(PRODUCT_DIR)/osmesa.dll',
- ],
},
}],
['OS=="win" and (fastbuild==0 or fastbuild==1)', {

Powered by Google App Engine
This is Rietveld 408576698