Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2797)

Unified Diff: chrome/interactive_ui_tests.isolate

Issue 813363003: Use Xvfb in isolated testing only if use_x11 is set (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/interactive_ui_tests.isolate
diff --git a/chrome/interactive_ui_tests.isolate b/chrome/interactive_ui_tests.isolate
index bef0495321515a156f9aefdd3f2cf49177e05d16..8fffce3eb4664bf309b77a130f0697a3060a3142 100644
--- a/chrome/interactive_ui_tests.isolate
+++ b/chrome/interactive_ui_tests.isolate
@@ -3,7 +3,7 @@
# found in the LICENSE file.
{
'conditions': [
- ['OS=="linux"', {
+ ['OS=="linux" and use_x11==1', {
'variables': {
'command': [
'../testing/xvfb.py',
@@ -15,17 +15,17 @@
],
'files': [
'../testing/xvfb.py',
- '<(PRODUCT_DIR)/libffmpegsumo.so',
- '<(PRODUCT_DIR)/libosmesa.so',
- '<(PRODUCT_DIR)/libppapi_tests.so',
- '<(PRODUCT_DIR)/pyproto/google/',
+ '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
],
},
}],
- ['OS=="linux" and use_ozone==0', {
+ ['OS=="linux"', {
'variables': {
'files': [
- '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
+ '<(PRODUCT_DIR)/libffmpegsumo.so',
+ '<(PRODUCT_DIR)/libosmesa.so',
+ '<(PRODUCT_DIR)/libppapi_tests.so',
+ '<(PRODUCT_DIR)/pyproto/google/',
],
},
}],
@@ -68,7 +68,7 @@
],
},
}],
- ['OS=="mac" or OS=="win"', {
+ ['OS=="mac" or OS=="win" or use_ozone==1', {
'variables': {
'command': [
'../testing/test_env.py',

Powered by Google App Engine
This is Rietveld 408576698