Use Xvfb in isolated testing only if use_x11 is set

ash/ash_unittests.isolate

 # Copyright (c) 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 {
   'conditions': [
     ['OS=="win" or chromeos==1', {
       'variables': {
         'files': [
           '../testing/test_env.py',
           '<(PRODUCT_DIR)/ash_unittests<(EXECUTABLE_SUFFIX)',
           '<(PRODUCT_DIR)/chrome_100_percent.pak',
           '<(PRODUCT_DIR)/chrome_200_percent.pak',
           '<(PRODUCT_DIR)/locales/en-US.pak',
           '<(PRODUCT_DIR)/keyboard_resources.pak',
         ],
       },
     }],
-    ['OS=="linux"', {
+    ['OS=="linux" and use_x11==1', {

[M-A Ruel, 2015/01/07 21:43:07]

I'd prefer to simplify the condition;

['use_x11==1', {
  'command': [
    xvfb.py PRODUCT_DIR ...
  ],
  'files': [ xvfb.py and xdisplaycheck ],
}
['use_x11==0', {
  'command': [
    '../testing/test_env.py',
    '<(PRODUCT_DIR)/ash_unittests<(EXECUTABLE_SUFFIX)',
    '--test-launcher-bot-mode',
  ],
}

[spang, 2015/01/07 21:59:17]

Done.

       'variables': {
         'command': [
           '../testing/xvfb.py',
           '<(PRODUCT_DIR)',
           '<(PRODUCT_DIR)/ash_unittests',
           '--test-launcher-bot-mode',
         ],
         'files': [
           '../testing/xvfb.py',
+          '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
+        ],
+      },
+    }],
+    ['OS=="linux"', {
+      'variables': {
+        'files': [
           '<(PRODUCT_DIR)/libffmpegsumo.so',
           '<(PRODUCT_DIR)/libosmesa.so',
         ],
       },
     }],
-    ['OS=="linux" and use_ozone==0', {
-      'variables': {
-        'files': [
-          '<(PRODUCT_DIR)/xdisplaycheck<(EXECUTABLE_SUFFIX)',
-        ],
-      },
-    }],
     ['OS=="win"', {
       'variables': {
-        'command': [
-          '../testing/test_env.py',
-          '<(PRODUCT_DIR)/ash_unittests.exe',
-          '--test-launcher-bot-mode',
-        ],
         'files': [
           '<(PRODUCT_DIR)/ffmpegsumo.dll',
           '<(PRODUCT_DIR)/osmesa.dll',
         ],
       },
     }],
+    ['OS=="win" or use_ozone==1', {
+      'variables': {
+        'command': [
+          '../testing/test_env.py',
+          '<(PRODUCT_DIR)/ash_unittests<(EXECUTABLE_SUFFIX)',
+          '--test-launcher-bot-mode',
+        ],
+      },
+    }],
     ['OS=="win" and (fastbuild==0 or fastbuild==1)', {
       'variables': {
         'files': [
           '<(PRODUCT_DIR)/ash_unittests.exe.pdb',
         ],
       },
     }],
   ],
   'includes': [
     '../base/base.isolate',
   ],
 }