Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 813353004: Change location of Rotation Lock in System Tray (Closed)

Created:
5 years, 11 months ago by jonross
Modified:
5 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change location of Rotation Lock in System Tray The rotation lock tray was in an incorrect position within the system tray. This change moves it to be above the Settings item. TEST=Have a device in maximize mode, open the system tray. BUG=443654 Committed: https://crrev.com/977738ffc224913439d1b7dac8560d11de31e0cb Cr-Commit-Position: refs/heads/master@{#310168}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ash/system/tray/system_tray.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
jonross
Hi Stefan, Could you provide an owner review of this change? I'm just moving the ...
5 years, 11 months ago (2015-01-06 21:48:11 UTC) #2
Mr4D (OOO till 08-26)
lgtm
5 years, 11 months ago (2015-01-06 22:34:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813353004/1
5 years, 11 months ago (2015-01-06 22:36:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 11 months ago (2015-01-06 23:23:12 UTC) #6
commit-bot: I haz the power
5 years, 11 months ago (2015-01-06 23:24:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/977738ffc224913439d1b7dac8560d11de31e0cb
Cr-Commit-Position: refs/heads/master@{#310168}

Powered by Google App Engine
This is Rietveld 408576698