Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: runtime/vm/code_generator.cc

Issue 81333003: Do not eagerly finalize classes in CHA, instead regard unfinalized classes as ’non-existent’ an… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/code_generator.h" 5 #include "vm/code_generator.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/ast.h" 8 #include "vm/ast.h"
9 #include "vm/bigint_operations.h" 9 #include "vm/bigint_operations.h"
10 #include "vm/code_patcher.h" 10 #include "vm/code_patcher.h"
(...skipping 1517 matching lines...) Expand 10 before | Expand all | Expand 10 after
1528 Code& optimized_code = Code::Handle(); 1528 Code& optimized_code = Code::Handle();
1529 while (frame != NULL) { 1529 while (frame != NULL) {
1530 optimized_code = frame->LookupDartCode(); 1530 optimized_code = frame->LookupDartCode();
1531 if (optimized_code.is_optimized()) { 1531 if (optimized_code.is_optimized()) {
1532 const intptr_t owner_cid = Class::Handle(Function::Handle( 1532 const intptr_t owner_cid = Class::Handle(Function::Handle(
1533 optimized_code.function()).Owner()).id(); 1533 optimized_code.function()).Owner()).id();
1534 if (ContainsCid(classes, owner_cid)) { 1534 if (ContainsCid(classes, owner_cid)) {
1535 DeoptimizeAt(optimized_code, frame->pc()); 1535 DeoptimizeAt(optimized_code, frame->pc());
1536 } 1536 }
1537 } 1537 }
1538 frame = iterator.NextFrame();
regis 2013/11/21 21:48:18 How could this loop terminate before? Was it never
srdjan 2013/11/21 22:25:00 It was never executed. The code used to be called
1538 } 1539 }
1539 } 1540 }
1540 1541
1541 1542
1542 static void CopySavedRegisters(uword saved_registers_address, 1543 static void CopySavedRegisters(uword saved_registers_address,
1543 fpu_register_t** fpu_registers, 1544 fpu_register_t** fpu_registers,
1544 intptr_t** cpu_registers) { 1545 intptr_t** cpu_registers) {
1545 ASSERT(sizeof(fpu_register_t) == kFpuRegisterSize); 1546 ASSERT(sizeof(fpu_register_t) == kFpuRegisterSize);
1546 fpu_register_t* fpu_registers_copy = 1547 fpu_register_t* fpu_registers_copy =
1547 new fpu_register_t[kNumberOfFpuRegisters]; 1548 new fpu_register_t[kNumberOfFpuRegisters];
(...skipping 150 matching lines...) Expand 10 before | Expand all | Expand 10 after
1698 // of the given value. 1699 // of the given value.
1699 // Arg0: Field object; 1700 // Arg0: Field object;
1700 // Arg1: Value that is being stored. 1701 // Arg1: Value that is being stored.
1701 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) { 1702 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
1702 const Field& field = Field::CheckedHandle(arguments.ArgAt(0)); 1703 const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
1703 const Object& value = Object::Handle(arguments.ArgAt(1)); 1704 const Object& value = Object::Handle(arguments.ArgAt(1));
1704 field.UpdateGuardedCidAndLength(value); 1705 field.UpdateGuardedCidAndLength(value);
1705 } 1706 }
1706 1707
1707 } // namespace dart 1708 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698