Do not eagerly finalize classes in CHA, instead regard unfinalized classes as ’non-existent’ an…

runtime/vm/code_generator.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/code_generator.h"
 
 #include "vm/assembler.h"
 #include "vm/ast.h"
 #include "vm/bigint_operations.h"
 #include "vm/code_patcher.h"
@@ skipping 1517 matching lines @@
   Code& optimized_code = Code::Handle();
   while (frame != NULL) {
     optimized_code = frame->LookupDartCode();
     if (optimized_code.is_optimized()) {
       const intptr_t owner_cid = Class::Handle(Function::Handle(
           optimized_code.function()).Owner()).id();
       if (ContainsCid(classes, owner_cid)) {
         DeoptimizeAt(optimized_code, frame->pc());
       }
     }
+    frame = iterator.NextFrame();

[regis, 2013/11/21 21:48:18]

How could this loop terminate before? Was it never executed?

[srdjan, 2013/11/21 22:25:00]

It was never executed. The code used to be called at lazy script loading, which
always occurred with no dart frame on stack.

   }
 }
 
 
 static void CopySavedRegisters(uword saved_registers_address,
                                fpu_register_t** fpu_registers,
                                intptr_t** cpu_registers) {
   ASSERT(sizeof(fpu_register_t) == kFpuRegisterSize);
   fpu_register_t* fpu_registers_copy =
       new fpu_register_t[kNumberOfFpuRegisters];
@@ skipping 150 matching lines @@
 // of the given value.
 //   Arg0: Field object;
 //   Arg1: Value that is being stored.
 DEFINE_RUNTIME_ENTRY(UpdateFieldCid, 2) {
   const Field& field = Field::CheckedHandle(arguments.ArgAt(0));
   const Object& value = Object::Handle(arguments.ArgAt(1));
   field.UpdateGuardedCidAndLength(value);
 }
 
 }  // namespace dart