Do not eagerly finalize classes in CHA, instead regard unfinalized classes as ’non-existent’ an…

runtime/vm/class_finalizer_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
 #include "vm/symbols.h"
 #include "vm/unit_test.h"
 
 namespace dart {
@@ skipping 22 matching lines @@
   classes_1.Add(&Class::Handle(CreateTestClass("Porsche")));
   pending_classes.Add(*classes_1[1]);
 
   GrowableArray<const Class*> classes_2;
   classes_2.Add(&Class::ZoneHandle(CreateTestClass("Ferrari")));
   pending_classes.Add(*classes_2[0]);
   classes_2.Add(&Class::ZoneHandle(CreateTestClass("Fiat")));
   pending_classes.Add(*classes_2[1]);
   classes_2.Add(&Class::ZoneHandle(CreateTestClass("Alfa")));
   pending_classes.Add(*classes_2[2]);
-  EXPECT(ClassFinalizer::FinalizePendingClasses());
+  EXPECT(ClassFinalizer::FinalizePendingClassInterfaces());
   for (int i = 0; i < classes_1.length(); i++) {
     EXPECT(classes_1[i]->is_type_finalized());
   }
   for (int i = 0; i < classes_2.length(); i++) {
     EXPECT(classes_2[i]->is_type_finalized());
   }
   EXPECT(ClassFinalizer::AllClassesFinalized());
-  EXPECT(ClassFinalizer::FinalizePendingClasses());
+  EXPECT(ClassFinalizer::FinalizePendingClassInterfaces());
 }
 
 
 TEST_CASE(ClassFinalize_Cycles) {
   Isolate* isolate = Isolate::Current();
   ObjectStore* object_store = isolate->object_store();
   const GrowableObjectArray& pending_classes =
       GrowableObjectArray::Handle(isolate, object_store->pending_classes());
   GrowableArray<const Class*> classes;
   classes.Add(&Class::Handle(CreateTestClass("Jungfrau")));
   pending_classes.Add(*classes[0]);
   classes.Add(&Class::Handle(CreateTestClass("Eiger")));
   pending_classes.Add(*classes[1]);
   // Create a cycle.
   classes[0]->set_super_type(
       Type::Handle(Type::NewNonParameterizedType(*classes[1])));
   classes[1]->set_super_type(
       Type::Handle(Type::NewNonParameterizedType(*classes[0])));
-  EXPECT(!ClassFinalizer::FinalizePendingClasses());
+  EXPECT(!ClassFinalizer::FinalizePendingClassInterfaces());
 }
 
 
 static RawLibrary* NewLib(const char* url_chars) {
   String& url = String::ZoneHandle(Symbols::New(url_chars));
   return Library::New(url);
 }
 
 
 TEST_CASE(ClassFinalize_Resolve) {
@@ skipping 11 matching lines @@
   const String& superclass_name = String::Handle(sbb.Name());
   const UnresolvedClass& unresolved = UnresolvedClass::Handle(
       UnresolvedClass::New(LibraryPrefix::Handle(),
                            superclass_name,
                            Scanner::kDummyTokenIndex));
   const TypeArguments& type_arguments = TypeArguments::Handle();
   rhb.set_super_type(Type::Handle(
       Type::New(Object::Handle(unresolved.raw()),
                 type_arguments,
                 Scanner::kDummyTokenIndex)));
-  EXPECT(ClassFinalizer::FinalizePendingClasses());
+  EXPECT(ClassFinalizer::FinalizePendingClassInterfaces());
 }
 
 }  // namespace dart