Add easyUnlockPrivate.getConnection API.

Add easyUnlockPrivate.getConnection API to allow querying for a Bluetooth connection's RSSI and TX power.

BUG=403419
Committed: https://crrev.com/6173774722d1b10afe61dc0a9c01c37930454953
Cr-Commit-Position: refs/heads/master@{#310687}

[Tim Song, 2015-01-08 18:28:50]

tengs@chromium.org changed reviewers:
+ isherman@chromium.org, yoz@chromium.org

[Tim Song, 2015-01-08 18:28:51]

+isherman@ for review
+yoz@ for .idl file

[Yoyo Zhou, 2015-01-08 20:23:05]

idl LGTM

https://codereview.chromium.org/813303003/diff/20001/chrome/browser/extension...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://codereview.chromium.org/813303003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:738:
return true;
Aside: It looks like BluetoothExtensionFunction just ignores these return
values, and they're not documented either =(. Why do you return the values you
have chosen here?

https://codereview.chromium.org/813303003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/813303003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:188: // Callback for
|getConnectionInfo()| method.
nit: Callback for the ...
I think it's also worth documenting the parameters.

[Ilya Sherman, 2015-01-08 20:46:00]

LGTM, thanks.

[Tim Song, 2015-01-09 00:31:46]

https://codereview.chromium.org/813303003/diff/20001/chrome/browser/extension...
File
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc
(right):

https://codereview.chromium.org/813303003/diff/20001/chrome/browser/extension...
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_api.cc:738:
return true;
On 2015/01/08 20:23:05, Yoyo Zhou wrote:
> Aside: It looks like BluetoothExtensionFunction just ignores these return
> values, and they're not documented either =(. Why do you return the values you
> have chosen here?

I followed the styles of the other subclasses that return true if the API
function call completes after the DoWork() call. This is similar to
AsyncExtensionFunction::Run().

Maybe the return value was relevant in the past and is redundant now due to
refactoring?

https://codereview.chromium.org/813303003/diff/20001/chrome/common/extensions...
File chrome/common/extensions/api/easy_unlock_private.idl (right):

https://codereview.chromium.org/813303003/diff/20001/chrome/common/extensions...
chrome/common/extensions/api/easy_unlock_private.idl:188: // Callback for
|getConnectionInfo()| method.
On 2015/01/08 20:23:05, Yoyo Zhou wrote:
> nit: Callback for the ...
> I think it's also worth documenting the parameters.

Done.

[Tim Song, 2015-01-09 02:44:13]

The CQ bit was checked by tengs@chromium.org

[commit-bot: I haz the power, 2015-01-09 02:45:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/813303003/60001

[commit-bot: I haz the power, 2015-01-09 02:49:52]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-09 02:50:46]

Patchset 4 (id:??) landed as
https://crrev.com/6173774722d1b10afe61dc0a9c01c37930454953
Cr-Commit-Position: refs/heads/master@{#310687}