Issue 813303002: Fix crash in Chromevox event handling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 813303002: Fix crash in Chromevox event handling (Closed)

Created:
6 years ago by Peter Lundblad

Modified:
5 years, 8 months ago

Reviewers:
David Tseng

CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nkostylev+watch_chromium.org, yuzo+watch_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, stevenjb+watch_chromium.org, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix crash in Chromevox event handling This guards against cases where visibility is checked on nodes such as the doctype of an element. BUG=None Committed: https://crrev.com/12c6c62f2112c35c9e5c084764b23efe40acf77b Cr-Commit-Position: refs/heads/master@{#322998}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	chrome/browser/resources/chromeos/chromevox/common/dom_util.js	View	1 2	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813303002/40001

5 years, 8 months ago (2015-03-31 08:27:20 UTC) #4

commit-bot: I haz the power

5 years, 8 months ago (2015-03-31 09:04:11 UTC) #6

Message was sent while issue was closed.

Patchset 3 (id:??) landed as
https://crrev.com/12c6c62f2112c35c9e5c084764b23efe40acf77b
Cr-Commit-Position: refs/heads/master@{#322998}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages