Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Issue 8133009: Avoid DefWindowProc non-client rendering over our custom frame. (Closed)

Created:
9 years, 2 months ago by msw
Modified:
9 years, 2 months ago
CC:
chromium-reviews, tfarina, dhollowa
Visibility:
Public.

Description

Avoid DefWindowProc non-client rendering over our custom frame. DefWindowProc handling of WM_NCACTIVATE renders the native frame. Handle the message ourselves when the Widget has a custom frame. BUG=90386 TEST=No xp/vista/7 classic/basic/aero artifacts on window [un-]focus. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=104051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M views/widget/native_widget_win.cc View 2 chunks +9 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
PTAL; thanks! Should I pursue M15 merge for a verified fix?
9 years, 2 months ago (2011-10-04 22:31:12 UTC) #1
sky
LGTM I would let this bake on canaray (and maybe a dev cycle too) before ...
9 years, 2 months ago (2011-10-04 23:03:55 UTC) #2
commit-bot: I haz the power
CQ is trying the patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8133009/1
9 years, 2 months ago (2011-10-05 01:08:55 UTC) #3
commit-bot: I haz the power
9 years, 2 months ago (2011-10-05 02:33:00 UTC) #4
Change committed as 104051

Powered by Google App Engine
This is Rietveld 408576698