Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Unified Diff: ui/file_manager/gallery/js/image_editor/image_view.js

Issue 813263002: Remove Gallery.Item when the corresponding entries are removed in file system. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/file_manager/gallery/js/gallery_scripts.js ('k') | ui/file_manager/gallery/js/ribbon.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/file_manager/gallery/js/image_editor/image_view.js
diff --git a/ui/file_manager/gallery/js/image_editor/image_view.js b/ui/file_manager/gallery/js/image_editor/image_view.js
index 26d50e1186d123bbfeeca7bd1cd3256a1952cda5..a7e411f4860f49f2834450b00de63c95ea3e5c41 100644
--- a/ui/file_manager/gallery/js/image_editor/image_view.js
+++ b/ui/file_manager/gallery/js/image_editor/image_view.js
@@ -653,12 +653,16 @@ ImageView.prototype.replace = function(
ImageUtil.setAttribute(newScreenImage, 'fade', false);
ImageUtil.setAttribute(oldScreenImage, 'fade', true);
var reverse = opt_effect.getReverse();
- assert(reverse);
- this.setTransform_(oldScreenImage, oldViewport, reverse);
- setTimeout(function() {
+ if (reverse) {
+ this.setTransform_(oldScreenImage, oldViewport, reverse);
+ setTimeout(function() {
+ if (oldScreenImage.parentNode)
+ oldScreenImage.parentNode.removeChild(oldScreenImage);
+ }, reverse.getSafeInterval());
+ } else {
if (oldScreenImage.parentNode)
oldScreenImage.parentNode.removeChild(oldScreenImage);
- }, reverse.getSafeInterval());
+ }
}
}.bind(this), 0);
};
« no previous file with comments | « ui/file_manager/gallery/js/gallery_scripts.js ('k') | ui/file_manager/gallery/js/ribbon.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698