Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 813263002: Remove Gallery.Item when the corresponding entries are removed in file system. (Closed)

Created:
6 years ago by hirono
Modified:
6 years ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove Gallery.Item when the corresponding entries are removed in file system. Gallery instantiates EntryListWatcher to delete gallery items at the time when the corresponding entry is removed on the files app. The CL also fixes the 'splice' event handling of UI classes in Gallery, which is called when the Gallery.Item is removed from ArrayDataList by EntryListWatcher. BUG=436350 TEST=None Committed: https://crrev.com/b9045d6cbbd7296a238b23fe7f0366eeb11f86e9 Cr-Commit-Position: refs/heads/master@{#309388}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -34 lines) Patch
M ui/file_manager/gallery/gallery.html View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/gallery.js View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M ui/file_manager/gallery/js/gallery_scripts.js View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/file_manager/gallery/js/image_editor/image_view.js View 1 chunk +8 lines, -4 lines 0 comments Download
M ui/file_manager/gallery/js/ribbon.js View 1 3 chunks +14 lines, -14 lines 0 comments Download
M ui/file_manager/gallery/js/slide_mode.js View 1 2 8 chunks +23 lines, -12 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
hirono
Remove Gallery.Item when the corresponding entries are removed in file system. Gallery instantiates EntryListWatcher to ...
6 years ago (2014-12-19 11:13:59 UTC) #2
hirono
PTAL the CL? Thanks!
6 years ago (2014-12-19 11:15:04 UTC) #3
fukino
On 2014/12/19 11:15:04, hirono wrote: > PTAL the CL? Thanks! lgtm, but could you update ...
6 years ago (2014-12-22 02:36:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813263002/40001
6 years ago (2014-12-22 03:13:25 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-22 03:28:12 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-22 03:28:56 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b9045d6cbbd7296a238b23fe7f0366eeb11f86e9
Cr-Commit-Position: refs/heads/master@{#309388}

Powered by Google App Engine
This is Rietveld 408576698