Source/core/css/CSSPrimitiveValue.h - Issue 813233002: Animation: Fix loss of type information when interpolating value of 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.h

Issue 813233002: Animation: Fix loss of type information when interpolating value of 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Removed changes to core.gypi, moved StringKeyframe, increased testing, added extra accumulate lengt… Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/animation/LengthStyleInterpolationTest.cpp ('k') | Source/core/css/CSSPrimitiveValue.cpp » ('j') | Source/core/css/CSSPrimitiveValue.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSPrimitiveValue.h

diff --git a/Source/core/css/CSSPrimitiveValue.h b/Source/core/css/CSSPrimitiveValue.h

index 11ad30d3a8ab9920a3b7539f607a54e499397448..fc1acd3ed4071f7fb9048198de6aaf5cfa0c14f7 100644

--- a/Source/core/css/CSSPrimitiveValue.h

+++ b/Source/core/css/CSSPrimitiveValue.h

@@ -26,6 +26,7 @@

#include "core/CSSValueKeywords.h"

#include "core/css/CSSValue.h"

#include "platform/graphics/Color.h"

+#include "wtf/BitVector.h"

#include "wtf/Forward.h"

#include "wtf/MathExtras.h"

#include "wtf/PassRefPtr.h"

@@ -150,7 +151,10 @@ public:

};

typedef Vector<double, CSSPrimitiveValue::LengthUnitTypeCount> CSSLengthArray;

+ typedef BitVector CSSLengthTypeArray;

void accumulateLengthArray(CSSLengthArray&, double multiplier = 1) const;

+ void accumulateLengthArray(CSSLengthArray&, CSSLengthTypeArray&, double multiplier = 1) const;

// This enum follows the BisonCSSParser::Units enum augmented with UNIT_FREQUENCY for frequencies.

enum UnitCategory {

« no previous file with comments | « Source/core/animation/LengthStyleInterpolationTest.cpp ('k') | Source/core/css/CSSPrimitiveValue.cpp » ('j') | Source/core/css/CSSPrimitiveValue.cpp » ('J')