Source/core/animation/StringKeyframe.cpp - Issue 813233002: Animation: Fix loss of type information when interpolating value of 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/StringKeyframe.cpp

Issue 813233002: Animation: Fix loss of type information when interpolating value of 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Attempt no2 at fixing linux oilpan errors Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/LengthStyleInterpolationTest.cpp ('K') | « Source/core/animation/LengthStyleInterpolationTest.cpp ('k') | Source/core/core.gypi » ('j') | Source/core/core.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/StringKeyframe.cpp

diff --git a/Source/core/animation/StringKeyframe.cpp b/Source/core/animation/StringKeyframe.cpp

index 9bf01dceb20993e21f45196a6c2e5184a43261bb..28dc674f59e023dd1acb1244f866aa19074d30f1 100644

--- a/Source/core/animation/StringKeyframe.cpp

+++ b/Source/core/animation/StringKeyframe.cpp

@@ -137,6 +137,17 @@ PassRefPtrWillBeRawPtr<Interpolation> StringKeyframe::PropertySpecificKeyframe::

case CSSPropertyWebkitTextStrokeColor:

if (ColorStyleInterpolation::canCreateFrom(*fromCSSValue) && ColorStyleInterpolation::canCreateFrom(*toCSSValue))

return ColorStyleInterpolation::create(*fromCSSValue, *toCSSValue, property);

+ case CSSPropertyBorderBottomLeftRadius:

+ case CSSPropertyBorderBottomRightRadius:

+ case CSSPropertyBorderTopLeftRadius:

+ case CSSPropertyBorderTopRightRadius:

+ range = ValueRangeNonNegative;

+ // Fall through

+ case CSSPropertyPerspectiveOrigin:

+ case CSSPropertyObjectPosition:

+ if (LengthPairStyleInterpolation::canCreateFrom(*fromCSSValue) && LengthPairStyleInterpolation::canCreateFrom(*toCSSValue))

+ return LengthPairStyleInterpolation::create(*fromCSSValue, *toCSSValue, property, range);

+ break;

samli 2014/12/22 03:38:04 Split this into a separate patch

default:

break;

}

« Source/core/animation/LengthStyleInterpolationTest.cpp ('K') | « Source/core/animation/LengthStyleInterpolationTest.cpp ('k') | Source/core/core.gypi » ('j') | Source/core/core.gypi » ('J')