Source/core/animation/LengthPairStyleInterpolationTest.cpp - Issue 813233002: Animation: Fix loss of type information when interpolating value of 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/LengthPairStyleInterpolationTest.cpp

Issue 813233002: Animation: Fix loss of type information when interpolating value of 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Attempt no2 at fixing linux oilpan errors Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/LengthPairStyleInterpolation.h ('K') | « Source/core/animation/LengthPairStyleInterpolation.cpp ('k') | Source/core/animation/LengthStyleInterpolation.cpp » ('j') | Source/core/animation/LengthStyleInterpolation.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/LengthPairStyleInterpolationTest.cpp

diff --git a/Source/core/animation/LengthPairStyleInterpolationTest.cpp b/Source/core/animation/LengthPairStyleInterpolationTest.cpp

index 400f7714308b7afe22575b53b4b44c82f9ad2e9a..1b6d10b40383843df680ddabb7a2cb0d57e9f7b4 100644

--- a/Source/core/animation/LengthPairStyleInterpolationTest.cpp

+++ b/Source/core/animation/LengthPairStyleInterpolationTest.cpp

@@ -59,19 +59,19 @@ TEST_F(LengthPairStyleInterpolationTest, ZeroTest)

RefPtrWillBeRawPtr<CSSPrimitiveValue> secondPc = CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_PERCENTAGE);

RefPtrWillBeRawPtr<Pair> pairPc = Pair::create(firstPc, secondPc, Pair::KeepIdenticalValues);

RefPtrWillBeRawPtr<CSSValue> value2 = roundTrip(CSSPrimitiveValue::create(pairPc.release()), ValueRangeNonNegative);

- testPrimitiveValue(value2, 0, 0, CSSPrimitiveValue::CSS_PX);

+ testPrimitiveValue(value2, 0, 0, CSSPrimitiveValue::CSS_PERCENTAGE);

RefPtrWillBeRawPtr<CSSPrimitiveValue> firstEms = CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_EMS);

RefPtrWillBeRawPtr<CSSPrimitiveValue> secondEms = CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_EMS);

RefPtrWillBeRawPtr<Pair> pairEms = Pair::create(firstEms, secondEms, Pair::KeepIdenticalValues);

RefPtrWillBeRawPtr<CSSValue> value3 = roundTrip(CSSPrimitiveValue::create(pairEms.release()), ValueRangeNonNegative);

- testPrimitiveValue(value3, 0, 0, CSSPrimitiveValue::CSS_PX);

+ testPrimitiveValue(value3, 0, 0, CSSPrimitiveValue::CSS_EMS);

RefPtrWillBeRawPtr<CSSPrimitiveValue> firstPcNeg = CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_PERCENTAGE);

RefPtrWillBeRawPtr<CSSPrimitiveValue> secondPcNeg = CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_PERCENTAGE);

RefPtrWillBeRawPtr<Pair> pairPcNeg = Pair::create(firstPcNeg, secondPcNeg, Pair::KeepIdenticalValues);

RefPtrWillBeRawPtr<CSSValue> value4 = roundTrip(CSSPrimitiveValue::create(pairPcNeg.release()), ValueRangeAll);

- testPrimitiveValue(value4, 0, 0, CSSPrimitiveValue::CSS_PX);

+ testPrimitiveValue(value4, 0, 0, CSSPrimitiveValue::CSS_PERCENTAGE);

}

TEST_F(LengthPairStyleInterpolationTest, MultipleValueTest)