Source/core/animation/LengthBoxStyleInterpolationTest.cpp - Issue 813233002: Animation: Fix loss of type information when interpolating value of 0

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/LengthBoxStyleInterpolationTest.cpp

Issue 813233002: Animation: Fix loss of type information when interpolating value of 0 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix second accumulateLength method Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/animation/LengthBoxStyleInterpolationTest.cpp

diff --git a/Source/core/animation/LengthBoxStyleInterpolationTest.cpp b/Source/core/animation/LengthBoxStyleInterpolationTest.cpp

index 28497c270d15fea03c4a20fec8b79f53211b70ed..90a7803add5d5a5eea21ebdbe7e7821e17e51631 100644

--- a/Source/core/animation/LengthBoxStyleInterpolationTest.cpp

+++ b/Source/core/animation/LengthBoxStyleInterpolationTest.cpp

@@ -65,7 +65,7 @@ TEST_F(AnimationLengthBoxStyleInterpolationTest, ZeroLengthBox)

rectEms->setBottom(CSSPrimitiveValue::create(0, CSSPrimitiveValue::CSS_EMS));

value = roundTrip(CSSPrimitiveValue::create(rectEms.release()));

- testPrimitiveValue(value, 0, 0, 0, 0, CSSPrimitiveValue::CSS_PX);

+ testPrimitiveValue(value, 0, 0, 0, 0, CSSPrimitiveValue::CSS_EMS);

}

TEST_F(AnimationLengthBoxStyleInterpolationTest, SingleUnitBox)

« no previous file with comments | « no previous file | Source/core/animation/LengthPairStyleInterpolationTest.cpp » ('j') | no next file with comments »