[ServiceWorker] Cache inspector out from flag, style & icon changes

[ServiceWorker] Cache inspector out from flag, style & icon changes:

* Added class to indexeddb & SW cache views to prevent double border
* Changed icon class of SW cache tree element to be the 'table' icon from indexeddb object store
* Changed the 'settings' key for the serviceworker tree element, which was mistakenly left the same as indexed db.
* Added 'border-bottom' style to the last element in both indexed db & SW cache grid view.

BUG=428015
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187574

[dmurph, 2014-12-18 23:35:55]

dmurph@chromium.org changed reviewers:
+ vsevik@chromium.org

[dmurph, 2014-12-18 23:35:56]

vsevik,

Please take a look.  I outlined the changes in the description.  Question: when
you said "move this out of experiments" in the bug, did you mean out from behind
the flag?  Or enabled by default?

Thanks,
Daniel

[vsevik, 2014-12-19 07:20:48]

lgtm

https://codereview.chromium.org/813173002/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/Main.js (left):

https://codereview.chromium.org/813173002/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/Main.js:145:
Runtime.experiments.register("serviceWorkerCacheInspection", "ServiceWorker
cache inspection", true);
You could just remove it altogether and remove the checks.
This will make this feature enabled by default and we can iterate incrementally
from there.

https://codereview.chromium.org/813173002/diff/1/Source/devtools/front_end/re...
File Source/devtools/front_end/resources/ResourcesPanel.js (right):

https://codereview.chromium.org/813173002/diff/1/Source/devtools/front_end/re...
Source/devtools/front_end/resources/ResourcesPanel.js:1544:
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, cacheId.name,
["indexed-db-object-store-storage-tree-item"]);
should it have service-worker in the class name here instead of indexed-db?

[dmurph, 2014-12-19 21:45:07]

https://codereview.chromium.org/813173002/diff/1/Source/devtools/front_end/ma...
File Source/devtools/front_end/main/Main.js (left):

https://codereview.chromium.org/813173002/diff/1/Source/devtools/front_end/ma...
Source/devtools/front_end/main/Main.js:145:
Runtime.experiments.register("serviceWorkerCacheInspection", "ServiceWorker
cache inspection", true);
On 2014/12/19 07:20:48, vsevik wrote:
> You could just remove it altogether and remove the checks.
> This will make this feature enabled by default and we can iterate
incrementally
> from there.

Done.

https://codereview.chromium.org/813173002/diff/1/Source/devtools/front_end/re...
File Source/devtools/front_end/resources/ResourcesPanel.js (right):

https://codereview.chromium.org/813173002/diff/1/Source/devtools/front_end/re...
Source/devtools/front_end/resources/ResourcesPanel.js:1544:
WebInspector.BaseStorageTreeElement.call(this, storagePanel, null, cacheId.name,
["indexed-db-object-store-storage-tree-item"]);
On 2014/12/19 07:20:48, vsevik wrote:
> should it have service-worker in the class name here instead of indexed-db?

This is for the icon.  I added serviceworker specific styles in the css now, and
just point them to the indexeddb icons.

[dmurph, 2014-12-19 21:45:25]

The CQ bit was checked by dmurph@chromium.org

[commit-bot: I haz the power, 2014-12-19 21:45:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/813173002/20001

[commit-bot: I haz the power, 2014-12-19 23:57:41]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187574