Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 813143002: [NaCl SDK] Disable relative import python presubmit warnings. (Closed)

Created:
6 years ago by binji
Modified:
6 years ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, cc-bugs_chromium.org, Sam Clegg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Disable relative import python presubmit warnings. The CQ fails otherwise. BUG=none R=sbc@chromium.org Committed: https://crrev.com/3f178cfa116c79caec62df13b123fb179507e085 Cr-Commit-Position: refs/heads/master@{#309102}

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M native_client_sdk/PRESUBMIT.py View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
binji
6 years ago (2014-12-18 21:20:16 UTC) #1
Sam Clegg
lgtm
6 years ago (2014-12-18 21:48:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813143002/40001
6 years ago (2014-12-18 23:21:12 UTC) #4
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years ago (2014-12-18 23:34:29 UTC) #5
commit-bot: I haz the power
6 years ago (2014-12-18 23:35:25 UTC) #6
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/3f178cfa116c79caec62df13b123fb179507e085
Cr-Commit-Position: refs/heads/master@{#309102}

Powered by Google App Engine
This is Rietveld 408576698