Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 813133004: [svg] Reset the initial view properly in SVGImage. (Closed)

Created:
6 years ago by Erik Dahlström (inactive)
Modified:
5 years, 11 months ago
Reviewers:
pdr., fs, chrishtr
CC:
blink-reviews, krit, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, f(malita), gyuyoung.kim_webkit.org, Stephen Chennney, pdr+svgwatchlist_chromium.org, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[svg] Reset the initial view properly in SVGImage. When a single svg is used several times on a page with different fragment identifiers, then we need to ensure that the initial view is reset properly if we switch from having a fragment to not having one. BUG=442226 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=188967

Patch Set 1 #

Patch Set 2 : add reftest #

Patch Set 3 : tweak test to avoid bug 444553 (separate issue) #

Total comments: 1

Patch Set 4 : rebase + add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -3 lines) Patch
A LayoutTests/svg/as-image/resources/svglogo.svg View 1 1 chunk +50 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/resources/svglogo-scale2.svg View 1 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/resources/svglogo-viewbox.svg View 1 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/svgview-references.html View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
A LayoutTests/svg/as-image/svgview-references-expected.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
M Source/core/frame/FrameView.cpp View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/svg/SVGSVGElement.cpp View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 2 3 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Erik Dahlström (inactive)
6 years ago (2014-12-19 16:23:30 UTC) #1
fs
lgtm https://codereview.chromium.org/813133004/diff/40001/Source/core/svg/graphics/SVGImage.cpp File Source/core/svg/graphics/SVGImage.cpp (right): https://codereview.chromium.org/813133004/diff/40001/Source/core/svg/graphics/SVGImage.cpp#newcode289 Source/core/svg/graphics/SVGImage.cpp:289: view->scrollToFragment(m_url); Maybe add a short note here as ...
5 years, 11 months ago (2015-01-26 12:06:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/813133004/60001
5 years, 11 months ago (2015-01-26 15:17:01 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-26 16:32:42 UTC) #6
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=188967

Powered by Google App Engine
This is Rietveld 408576698