Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4077)

Unified Diff: chrome/browser/signin/chrome_signin_client_factory.cc

Issue 813133003: New Profile metric for Auth Errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeSigninClient handles no ProfileManager for tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/signin/chrome_signin_client_factory.cc
diff --git a/chrome/browser/signin/chrome_signin_client_factory.cc b/chrome/browser/signin/chrome_signin_client_factory.cc
index 11ba30672a453c4ef88b6d29de83cd4986dd3cbe..38de748059a475daa6b4a5f0e766d28cf6883b52 100644
--- a/chrome/browser/signin/chrome_signin_client_factory.cc
+++ b/chrome/browser/signin/chrome_signin_client_factory.cc
@@ -5,12 +5,15 @@
#include "chrome/browser/signin/chrome_signin_client_factory.h"
#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/signin/signin_error_controller_factory.h"
#include "components/keyed_service/content/browser_context_dependency_manager.h"
ChromeSigninClientFactory::ChromeSigninClientFactory()
: BrowserContextKeyedServiceFactory(
"ChromeSigninClient",
- BrowserContextDependencyManager::GetInstance()) {}
+ BrowserContextDependencyManager::GetInstance()) {
+ DependsOn(SigninErrorControllerFactory::GetInstance());
+}
ChromeSigninClientFactory::~ChromeSigninClientFactory() {}
@@ -27,7 +30,8 @@ ChromeSigninClientFactory* ChromeSigninClientFactory::GetInstance() {
KeyedService* ChromeSigninClientFactory::BuildServiceInstanceFor(
content::BrowserContext* context) const {
- ChromeSigninClient* client =
- new ChromeSigninClient(static_cast<Profile*>(context));
+ Profile* profile = static_cast<Profile*>(context);
+ ChromeSigninClient* client = new ChromeSigninClient(
+ profile, SigninErrorControllerFactory::GetForProfile(profile));
return client;
}
« no previous file with comments | « chrome/browser/signin/chrome_signin_client.cc ('k') | chrome/browser/signin/signin_global_error_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698