Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2448)

Unified Diff: chrome/browser/signin/chrome_signin_client.h

Issue 813133003: New Profile metric for Auth Errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: ChromeSigninClient handles no ProfileManager for tests Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/profiles/profile_metrics.cc ('k') | chrome/browser/signin/chrome_signin_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/signin/chrome_signin_client.h
diff --git a/chrome/browser/signin/chrome_signin_client.h b/chrome/browser/signin/chrome_signin_client.h
index 3a21c0b31433863402b4c00edd46d27a39a4975e..2dc44f091e3bf5d8a9abff4a16723328506a0075 100644
--- a/chrome/browser/signin/chrome_signin_client.h
+++ b/chrome/browser/signin/chrome_signin_client.h
@@ -8,15 +8,18 @@
#include "base/basictypes.h"
#include "base/compiler_specific.h"
#include "components/signin/core/browser/signin_client.h"
+#include "components/signin/core/browser/signin_error_controller.h"
#include "content/public/browser/render_process_host_observer.h"
class CookieSettings;
class Profile;
class ChromeSigninClient : public SigninClient,
- public content::RenderProcessHostObserver {
+ public content::RenderProcessHostObserver,
+ public SigninErrorController::Observer {
public:
- explicit ChromeSigninClient(Profile* profile);
+ explicit ChromeSigninClient(
+ Profile* profile, SigninErrorController* signin_error_controller);
~ChromeSigninClient() override;
// Utility methods.
@@ -65,9 +68,14 @@ class ChromeSigninClient : public SigninClient,
const std::string& username,
const std::string& password) override;
+ // SigninErrorController::Observer implementation.
+ void OnErrorChanged() override;
+
private:
Profile* profile_;
+ SigninErrorController* signin_error_controller_;
+
// See SetSigninProcess. Tracks the currently active signin process
// by ID, if there is one.
int signin_host_id_;
« no previous file with comments | « chrome/browser/profiles/profile_metrics.cc ('k') | chrome/browser/signin/chrome_signin_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698