Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: components/signin/core/browser/signin_error_controller.cc

Issue 813133003: New Profile metric for Auth Errors. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Headers cleanup Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_error_controller.cc
diff --git a/components/signin/core/browser/signin_error_controller.cc b/components/signin/core/browser/signin_error_controller.cc
index eb680105d10cb8a2674404d1a71b543ac518a3aa..b145cf9528ae7222e4cd2bfd080b66ee530f44f7 100644
--- a/components/signin/core/browser/signin_error_controller.cc
+++ b/components/signin/core/browser/signin_error_controller.cc
@@ -4,6 +4,9 @@
#include "components/signin/core/browser/signin_error_controller.h"
+#include "components/signin/core/browser/signin_client.h"
+#include "components/signin/core/browser/signin_metrics.h"
+
namespace {
typedef std::set<const SigninErrorController::AuthStatusProvider*>
@@ -17,8 +20,9 @@ SigninErrorController::AuthStatusProvider::AuthStatusProvider() {
SigninErrorController::AuthStatusProvider::~AuthStatusProvider() {
}
-SigninErrorController::SigninErrorController()
+SigninErrorController::SigninErrorController(SigninClient* signin_client)
: auth_error_(GoogleServiceAuthError::AuthErrorNone()) {
+ AddObserver(signin_client);
}
SigninErrorController::~SigninErrorController() {
@@ -92,6 +96,7 @@ void SigninErrorController::AuthStatusChanged() {
}
if (error_changed) {
+ signin_metrics::LogAuthError(auth_error_.state());
FOR_EACH_OBSERVER(Observer, observer_list_, OnErrorChanged());
}
}

Powered by Google App Engine
This is Rietveld 408576698