New Profile metric for Auth Errors.

components/signin/core/browser/signin_client.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_
 #define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_
 
 #include "base/callback.h"
 #include "base/callback_list.h"
 #include "base/time/time.h"
 #include "components/keyed_service/core/keyed_service.h"
+#include "components/signin/core/browser/signin_error_controller.h"
 #include "components/signin/core/browser/webdata/token_web_data.h"
 #include "net/cookies/cookie_store.h"
 #include "url/gurl.h"
 
 class PrefService;
 class SigninManagerBase;
 class TokenWebData;
 
 namespace net {
 class URLRequestContextGetter;
 }
 
 #if defined(OS_IOS)
 namespace ios {
 // TODO(msarda): http://crbug.com/358544 Remove this iOS specific code from the
 // core SigninClient.
 class ProfileOAuth2TokenServiceIOSProvider;
 }
 #endif
 
 // An interface that needs to be supplied to the Signin component by its
 // embedder.
-class SigninClient : public KeyedService {
+class SigninClient : public KeyedService,
+                     public SigninErrorController::Observer {

[Roger Tawa OOO till Jul 10th, 2015/01/06 22:32:42]

ChromeSigninClient should implement this interface directly instead of
inheriting from SigninClient.  It should then add itself as an observer when
created, instead of being added in the SigninErrorController ctor.

However, I see that this will create a circular PKS dependency chain: PO2TS ->
ChromeSigninClient -> PO2TS.  But it seems we are creating this dependency
anyway; since ChromeSigninClient::OnErrorChanged() calls on PO2TS,
ChromeSigninClientFactory should be updated to depend on PO2TSFactory.

We discussed making SigninErrorController its own PKS, but thought that was a
cleanup for later.  Maybe it should be done here.  Both PO2TS and
ChromeSigninClientFactory can depend on SigninErrorController, and the latter
depends on nothing.

  public:
   // The subcription for cookie changed notifications.
   class CookieChangedSubscription {
    public:
     virtual ~CookieChangedSubscription() {};
   };
 
   ~SigninClient() override {}
 
   // Gets the preferences associated with the client.
@@ skipping 54 matching lines @@
   virtual base::Time GetInstallDate() = 0;
 
 #if defined(OS_IOS)
   // TODO(msarda): http://crbug.com/358544 Remove this iOS specific code from
   // the core SigninClient.
   virtual ios::ProfileOAuth2TokenServiceIOSProvider* GetIOSProvider() = 0;
 #endif
 };
 
 #endif  // COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_