New Profile metric for Auth Errors.

chrome/browser/profiles/profile_info_cache.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_info_cache.h"
 
 #include "base/bind.h"
 #include "base/files/file_util.h"
 #include "base/i18n/case_conversion.h"
 #include "base/logging.h"
@@ skipping 40 matching lines @@
 const char kAvatarIconKey[] = "avatar_icon";
 const char kAuthCredentialsKey[] = "local_auth_credentials";
 const char kUseGAIAPictureKey[] = "use_gaia_picture";
 const char kBackgroundAppsKey[] = "background_apps";
 const char kGAIAPictureFileNameKey[] = "gaia_picture_file_name";
 const char kIsOmittedFromProfileListKey[] = "is_omitted_from_profile_list";
 const char kSigninRequiredKey[] = "signin_required";
 const char kSupervisedUserId[] = "managed_user_id";
 const char kProfileIsEphemeral[] = "is_ephemeral";
 const char kActiveTimeKey[] = "active_time";
+const char kAuthErrorKey[] = "auth_error";
 
 // First eight are generic icons, which use IDS_NUMBERED_PROFILE_NAME.
 const int kDefaultNames[] = {
   IDS_DEFAULT_AVATAR_NAME_8,
   IDS_DEFAULT_AVATAR_NAME_9,
   IDS_DEFAULT_AVATAR_NAME_10,
   IDS_DEFAULT_AVATAR_NAME_11,
   IDS_DEFAULT_AVATAR_NAME_12,
   IDS_DEFAULT_AVATAR_NAME_13,
   IDS_DEFAULT_AVATAR_NAME_14,
@@ skipping 377 matching lines @@
   GetInfoForProfileAtIndex(index)->GetBoolean(kIsUsingDefaultNameKey, &value);
   return value;
 }
 
 bool ProfileInfoCache::ProfileIsUsingDefaultAvatarAtIndex(size_t index) const {
   bool value = false;
   GetInfoForProfileAtIndex(index)->GetBoolean(kIsUsingDefaultAvatarKey, &value);
   return value;
 }
 
+GoogleServiceAuthError::State ProfileInfoCache::ProfileAuthErrorAtIndex(
+    size_t index) const {
+  int value;
+  GetInfoForProfileAtIndex(index)->GetInteger(kAuthErrorKey, &value);
+  if (value < GoogleServiceAuthError::State::NUM_STATES)
+    return static_cast<GoogleServiceAuthError::State>(value);
+  else

[noms (inactive), 2014/12/19 19:33:01]

nit: You don't need the else.

[Mike Lerman, 2014/12/19 19:53:18]

Done.

+    return GoogleServiceAuthError::State::NONE;
+}
+
 size_t ProfileInfoCache::GetAvatarIconIndexOfProfileAtIndex(size_t index)
     const {
   std::string icon_url;
   GetInfoForProfileAtIndex(index)->GetString(kAvatarIconKey, &icon_url);
   size_t icon_index = 0;
   if (!profiles::IsDefaultAvatarIconUrl(icon_url, &icon_index))
     DLOG(WARNING) << "Unknown avatar icon: " << icon_url;
 
   return icon_index;
 }
@@ skipping 272 matching lines @@
   SetInfoForProfileAtIndex(index, info.release());
 }
 
 void ProfileInfoCache::SetProfileIsUsingDefaultAvatarAtIndex(
     size_t index, bool value) {
   if (value == ProfileIsUsingDefaultAvatarAtIndex(index))
     return;
 
   scoped_ptr<base::DictionaryValue> info(
       GetInfoForProfileAtIndex(index)->DeepCopy());
-  info->SetBoolean(kIsUsingDefaultAvatarKey, value);
+  info->SetBoolean(kIsUsingDefaultAvatarKey, (int)value);

[noms (inactive), 2014/12/19 19:33:00]

Hmm, I don't understand this change. You are setting a boolean, and value is
already a boolean. Why is this needed?

[Mike Lerman, 2014/12/19 19:53:17]

Sorry, bad things with copy pasting.done.

   // This takes ownership of |info|.
   SetInfoForProfileAtIndex(index, info.release());
 }
+
+void ProfileInfoCache::SetProfileAuthErrorAtIndex(
+    size_t index, GoogleServiceAuthError::State value) {
+  if (value == ProfileAuthErrorAtIndex(index))
+    return;
+
+  scoped_ptr<base::DictionaryValue> info(
+      GetInfoForProfileAtIndex(index)->DeepCopy());
+  info->SetInteger(kAuthErrorKey, value);
+  // This takes ownership of |info|.
+  SetInfoForProfileAtIndex(index, info.release());
+}
 
 bool ProfileInfoCache::IsDefaultProfileName(const base::string16& name) const {
   // Check if it's a "First user" old-style name.
   if (name == l10n_util::GetStringUTF16(IDS_DEFAULT_PROFILE_NAME) ||
       name == l10n_util::GetStringUTF16(IDS_LEGACY_DEFAULT_PROFILE_NAME))
     return true;
 
   // Check if it's one of the old-style profile names.
   for (size_t i = 0; i < arraysize(kDefaultNames); ++i) {
     if (name == l10n_util::GetStringUTF16(kDefaultNames[i]))
@@ skipping 359 matching lines @@
   std::vector<base::FilePath>::const_iterator it;
   for (it = profiles_to_rename.begin(); it != profiles_to_rename.end(); ++it) {
     size_t profile_index = GetIndexOfProfileWithPath(*it);
     SetProfileIsUsingDefaultNameAtIndex(profile_index, true);
     // This will assign a new "Person %d" type name and re-sort the cache.
     SetNameOfProfileAtIndex(profile_index, ChooseNameForNewProfile(
         GetAvatarIconIndexOfProfileAtIndex(profile_index)));
   }
 #endif
 }