New Profile metric for Auth Errors.

chrome/browser/signin/signin_global_error.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/signin/signin_global_error.h"
 
 #include "base/logging.h"
 #include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/browser_process.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_info_cache.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/signin/signin_header_helper.h"
 #include "chrome/browser/signin/signin_manager_factory.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/chrome_pages.h"
 #include "chrome/browser/ui/global_error/global_error_service.h"
 #include "chrome/browser/ui/global_error/global_error_service_factory.h"
 #include "chrome/browser/ui/singleton_tabs.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service.h"
 #include "chrome/browser/ui/webui/signin/login_ui_service_factory.h"
@@ skipping 161 matching lines @@
 void SigninGlobalError::BubbleViewAcceptButtonPressed(Browser* browser) {
   ExecuteMenuItem(browser);
 }
 
 void SigninGlobalError::BubbleViewCancelButtonPressed(Browser* browser) {
   NOTREACHED();
 }
 
 void SigninGlobalError::OnErrorChanged() {
   GlobalErrorServiceFactory::GetForProfile(profile_)->NotifyErrorsChanged(this);
+
+  ProfileInfoCache& cache = g_browser_process->profile_manager()->
+      GetProfileInfoCache();
+  size_t index = cache.GetIndexOfProfileWithPath(profile_->GetPath());
+  if (index != std::string::npos) {
+    cache.SetProfileAuthErrorAtIndex(index,
+                                     error_controller_->auth_error().state());
+  }

[Roger Tawa OOO till Jul 10th, 2014/12/19 19:52:33]

Why not just call UMA_HISTOGRAM_ENUMERATION right here?

Are you sure this is comparable to Profile.NumberOfProfiles and
Profile.NumberOfSignedInProfiles?  How often is OnErrorChagned() called?

I don't believe SigninGlobalError is used on all platforms.  May be better to
move this to SigninErrorController::AuthStatusChanged(), right before calling
OnErrorChanged().

[Mike Lerman, 2015/01/05 20:24:02]

The answer to the first two questions is the same: By making
ProfileMetrics::LogNumbersOfProfiles responsible for calling UMA_HISTOGRAMS we
always log the Profile.NumberOf* histograms at the same times in a comparable
way.

Moved into SigninErrorController. SigninGlobalError just sets the bit as to
whether an error has occured or not. 

 }