Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 812993008: Revert of choose better mip level

Created:
5 years, 11 months ago by reed1
Modified:
5 years, 11 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of choose better mip level (patchset #2 id:20001 of https://codereview.chromium.org/845793005/) Reason for revert: need more suppressions Original issue's description: > choose better mip level > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/09544fcf9611be6efc0c38ab9d9a3f82181341fb TBR=robertphillips@google.com NOTREECHECKS=true NOTRY=true BUG=skia:

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M expectations/gm/ignored-tests.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M src/core/SkMipMap.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
reed1
Created Revert of choose better mip level
5 years, 11 months ago (2015-01-15 16:24:04 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812993008/1
5 years, 11 months ago (2015-01-15 16:24:44 UTC) #2
commit-bot: I haz the power
5 years, 11 months ago (2015-01-15 16:24:48 UTC) #4
Failed to apply patch for expectations/gm/ignored-tests.txt:
While running git apply --index -3 -p1;
  error: patch failed: expectations/gm/ignored-tests.txt:40
  Falling back to three-way merge...
  Applied patch to 'expectations/gm/ignored-tests.txt' with conflicts.
  U expectations/gm/ignored-tests.txt

Patch:       expectations/gm/ignored-tests.txt
Index: expectations/gm/ignored-tests.txt
diff --git a/expectations/gm/ignored-tests.txt
b/expectations/gm/ignored-tests.txt
index
c5ff2831c2b11581af09229dc215fe39bbc691f5..e692860c948c0a641d84fb25e3ed91914736e2f5
100644
--- a/expectations/gm/ignored-tests.txt
+++ b/expectations/gm/ignored-tests.txt
@@ -40,9 +40,3 @@
 # New shadow only option in SkDropShadowImageFilter
 dropshadowimagefilter
 
-# reed - rebase after mipmap level improvement
-downsamplebitmap_image_medium_mandrill_512
-downsamplebitmap_image_medium_mandrill_132x132_12x12
-downsamplebitmap_checkerboard_medium_512_256
-downsamplebitmap_text_medium_72.00pt
-filterindiabox

Powered by Google App Engine
This is Rietveld 408576698