Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: src/compiler/instruction.cc

Issue 812983002: [turbofan] Skip printing of empty gap moves. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/instruction.cc
diff --git a/src/compiler/instruction.cc b/src/compiler/instruction.cc
index ba72eda2ec73ff58018c2b3a83ab45f301e106ed..962548a48e60ae8deb49bab63909a5de7baa7503 100644
--- a/src/compiler/instruction.cc
+++ b/src/compiler/instruction.cc
@@ -287,16 +287,18 @@ std::ostream& operator<<(std::ostream& os,
if (instr.IsGapMoves()) {
const GapInstruction* gap = GapInstruction::cast(&instr);
- os << "gap ";
- for (int i = GapInstruction::FIRST_INNER_POSITION;
- i <= GapInstruction::LAST_INNER_POSITION; i++) {
- os << "(";
- if (gap->parallel_moves_[i] != NULL) {
- PrintableParallelMove ppm = {printable.register_configuration_,
- gap->parallel_moves_[i]};
- os << ppm;
+ if (!gap->IsRedundant()) {
+ os << "gap ";
+ for (int i = GapInstruction::FIRST_INNER_POSITION;
+ i <= GapInstruction::LAST_INNER_POSITION; i++) {
+ os << "(";
+ if (gap->parallel_moves_[i] != NULL) {
+ PrintableParallelMove ppm = {printable.register_configuration_,
+ gap->parallel_moves_[i]};
+ os << ppm;
+ }
+ os << ") ";
}
- os << ") ";
}
} else if (instr.IsSourcePosition()) {
const SourcePositionInstruction* pos =
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698