[Ozone-Dri] Create GbmWrapper

[Ozone-Dri] Create GbmWrapper

The GBM device is tightly coupled with the DRM FD and GBM code would
need to access both when allocating/registering the buffers.

BUG=427959
NOTRY=true

Committed: https://crrev.com/7283911c9ef1116e8dc70af104975c828e244150
Cr-Commit-Position: refs/heads/master@{#312663}

[dnicoara, 2015-01-21 20:57:19]

dnicoara@chromium.org changed reviewers:
+ alexst@chromium.org

[dnicoara, 2015-01-21 20:57:20]

PTAL

[alexst (slow to review), 2015-01-21 22:35:40]

lgtm with nits

https://codereview.chromium.org/812933003/diff/1/ui/ozone/platform/dri/gbm_wr...
File ui/ozone/platform/dri/gbm_wrapper.h (right):

https://codereview.chromium.org/812933003/diff/1/ui/ozone/platform/dri/gbm_wr...
ui/ozone/platform/dri/gbm_wrapper.h:21: void Initialize() override;
Please mention this is from DriWrapper in a comment.

https://codereview.chromium.org/812933003/diff/1/ui/ozone/platform/dri/ozone_...
File ui/ozone/platform/dri/ozone_platform_gbm.cc (right):

https://codereview.chromium.org/812933003/diff/1/ui/ozone/platform/dri/ozone_...
ui/ozone/platform/dri/ozone_platform_gbm.cc:63: // HACK: gbm drivers have broken
linkage
Period at the end of the sentence, and please explain the hack and why it's
needed in more detail.

[dnicoara, 2015-01-21 22:51:13]

https://codereview.chromium.org/812933003/diff/1/ui/ozone/platform/dri/gbm_wr...
File ui/ozone/platform/dri/gbm_wrapper.h (right):

https://codereview.chromium.org/812933003/diff/1/ui/ozone/platform/dri/gbm_wr...
ui/ozone/platform/dri/gbm_wrapper.h:21: void Initialize() override;
On 2015/01/21 22:35:40, alexst wrote:
> Please mention this is from DriWrapper in a comment.

Done.

https://codereview.chromium.org/812933003/diff/1/ui/ozone/platform/dri/ozone_...
File ui/ozone/platform/dri/ozone_platform_gbm.cc (right):

https://codereview.chromium.org/812933003/diff/1/ui/ozone/platform/dri/ozone_...
ui/ozone/platform/dri/ozone_platform_gbm.cc:63: // HACK: gbm drivers have broken
linkage
On 2015/01/21 22:35:40, alexst wrote:
> Period at the end of the sentence, and please explain the hack and why it's
> needed in more detail.

Done.

[alexst (slow to review), 2015-01-21 22:54:52]

lgtm

https://codereview.chromium.org/812933003/diff/20001/ui/ozone/platform/dri/gb...
File ui/ozone/platform/dri/gbm_wrapper.h (right):

https://codereview.chromium.org/812933003/diff/20001/ui/ozone/platform/dri/gb...
ui/ozone/platform/dri/gbm_wrapper.h:21: // DriWrapper overrides:
The convention elsewhere is

// DriWrapper implementation:

being pedantic, sorry :)

[dnicoara, 2015-01-21 23:05:44]

https://codereview.chromium.org/812933003/diff/20001/ui/ozone/platform/dri/gb...
File ui/ozone/platform/dri/gbm_wrapper.h (right):

https://codereview.chromium.org/812933003/diff/20001/ui/ozone/platform/dri/gb...
ui/ozone/platform/dri/gbm_wrapper.h:21: // DriWrapper overrides:
On 2015/01/21 22:54:52, alexst wrote:
> The convention elsewhere is
> 
> // DriWrapper implementation:
> 
> being pedantic, sorry :)

Done.

$ git gs "implementation:" | wc -l
1176
$ git gs "overrides:" | wc -l
1074

Interestingly the view is split on this one. Of course the the grep does not
include all the broken variations.

[alexst (slow to review), 2015-01-21 23:29:32]

On 2015/01/21 23:05:44, dnicoara wrote:
>
https://codereview.chromium.org/812933003/diff/20001/ui/ozone/platform/dri/gb...
> File ui/ozone/platform/dri/gbm_wrapper.h (right):
> 
>
https://codereview.chromium.org/812933003/diff/20001/ui/ozone/platform/dri/gb...
> ui/ozone/platform/dri/gbm_wrapper.h:21: // DriWrapper overrides:
> On 2015/01/21 22:54:52, alexst wrote:
> > The convention elsewhere is
> > 
> > // DriWrapper implementation:
> > 
> > being pedantic, sorry :)
> 
> Done.
> 
> $ git gs "implementation:" | wc -l
> 1176
> $ git gs "overrides:" | wc -l
> 1074
> 
> Interestingly the view is split on this one. Of course the the grep does not
> include all the broken variations.

Fascinating! Okay, I take my statement back, it seems either way is good, we are
all inconsistent fools. :) We should just call it overimplementationwhynot:

[dnicoara, 2015-01-22 20:12:53]

The CQ bit was checked by dnicoara@chromium.org

[dnicoara, 2015-01-22 20:12:59]

The CQ bit was unchecked by dnicoara@chromium.org

[dnicoara, 2015-01-22 20:13:09]

The CQ bit was checked by dnicoara@chromium.org

[commit-bot: I haz the power, 2015-01-22 20:14:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812933003/60001

[commit-bot: I haz the power, 2015-01-22 20:16:12]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-01-22 20:17:15]

Patchset 4 (id:??) landed as
https://crrev.com/7283911c9ef1116e8dc70af104975c828e244150
Cr-Commit-Position: refs/heads/master@{#312663}

[varkha, 2015-03-16 20:45:07]

varkha@chromium.org changed reviewers:
+ varkha@chromium.org

[varkha, 2015-03-16 20:45:07]

https://codereview.chromium.org/812933003/diff/20001/ui/ozone/platform/dri/gb...
File ui/ozone/platform/dri/gbm_wrapper.h (right):

https://codereview.chromium.org/812933003/diff/20001/ui/ozone/platform/dri/gb...
ui/ozone/platform/dri/gbm_wrapper.h:21: // DriWrapper overrides:
On 2015/01/21 23:05:44, dnicoara wrote:
> On 2015/01/21 22:54:52, alexst wrote:
> > The convention elsewhere is
> > 
> > // DriWrapper implementation:
> > 
> > being pedantic, sorry :)
> 
> Done.
> 
> $ git gs "implementation:" | wc -l
> 1176
> $ git gs "overrides:" | wc -l
> 1074
> 
> Interestingly the view is split on this one. Of course the the grep does not
> include all the broken variations.

I think a more popular variant now (I got into similar discussion elsewhere
recently) is just " // <Interface>:" which is a bit shorter.
within src/chrome (about a week ago stats):
82 of // FooBar
648 of // FooBar:
346 of // FooBar [Oo]verride*