ozone: fix HDPMLegacy - do the PF after overlays, also clear old overlays

ozone: fix HDPMLegacy - do the PF after overlays, also clear old overlays

This lets overlays display properly in the case of switching on/off

Committed: https://crrev.com/ff2799d09a2f6a8ffc6dcceff1fbd8a63578a80d
Cr-Commit-Position: refs/heads/master@{#313826}

[achaulk, 2015-01-16 21:33:24]

achaulk@chromium.org changed reviewers:
+ dnicoara@chromium.org

[dnicoara, 2015-01-16 21:40:09]

Overall looks good. Maybe add a unit test for to test the release of unused
planes.

https://codereview.chromium.org/812913003/diff/1/ui/ozone/platform/dri/hardwa...
File ui/ozone/platform/dri/hardware_display_plane_manager_legacy.cc (right):

https://codereview.chromium.org/812913003/diff/1/ui/ozone/platform/dri/hardwa...
ui/ozone/platform/dri/hardware_display_plane_manager_legacy.cc:25: for (const
auto& flip : plane_list->legacy_page_flips) {
Add a comment before the for-loop mentioning why this needs to happen before the
page flip.

https://codereview.chromium.org/812913003/diff/1/ui/ozone/platform/dri/hardwa...
ui/ozone/platform/dri/hardware_display_plane_manager_legacy.cc:51: for
(HardwareDisplayPlane* plane : plane_list->old_plane_list) {
Should this be done before the PageFlip()? I think that if we're doing it after
it may result in old planes being shown when they shouldn't.

Also could you add a comment right before the for-loop explaining what this
does, just to make it easier for other readers.

[achaulk, 2015-01-21 21:50:53]

https://chromiumcodereview.appspot.com/812913003/diff/1/ui/ozone/platform/dri...
File ui/ozone/platform/dri/hardware_display_plane_manager_legacy.cc (right):

https://chromiumcodereview.appspot.com/812913003/diff/1/ui/ozone/platform/dri...
ui/ozone/platform/dri/hardware_display_plane_manager_legacy.cc:25: for (const
auto& flip : plane_list->legacy_page_flips) {
On 2015/01/16 21:40:08, dnicoara wrote:
> Add a comment before the for-loop mentioning why this needs to happen before
the
> page flip.

Done.

https://chromiumcodereview.appspot.com/812913003/diff/1/ui/ozone/platform/dri...
ui/ozone/platform/dri/hardware_display_plane_manager_legacy.cc:51: for
(HardwareDisplayPlane* plane : plane_list->old_plane_list) {
On 2015/01/16 21:40:08, dnicoara wrote:
> Should this be done before the PageFlip()? I think that if we're doing it
after
> it may result in old planes being shown when they shouldn't.
> 
> Also could you add a comment right before the for-loop explaining what this
> does, just to make it easier for other readers.

No, it only changes planes that haven't been re-used elsewhere

[dnicoara, 2015-01-21 21:54:28]

Thanks!

lgtm

[achaulk, 2015-01-23 20:25:26]

The CQ bit was checked by achaulk@chromium.org

[achaulk, 2015-01-23 20:25:28]

The CQ bit was unchecked by achaulk@chromium.org

[achaulk, 2015-01-27 18:44:52]

The CQ bit was checked by achaulk@chromium.org

[commit-bot: I haz the power, 2015-01-27 18:46:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812913003/20001

[achaulk, 2015-01-27 19:00:43]

The CQ bit was unchecked by achaulk@chromium.org

[achaulk, 2015-01-29 23:29:15]

The CQ bit was checked by achaulk@chromium.org

[commit-bot: I haz the power, 2015-01-29 23:29:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812913003/20001

[commit-bot: I haz the power, 2015-01-29 23:31:01]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-29 23:32:08]

Patchset 2 (id:??) landed as
https://crrev.com/ff2799d09a2f6a8ffc6dcceff1fbd8a63578a80d
Cr-Commit-Position: refs/heads/master@{#313826}