Issue 812853002: Basic tests for sending messages over a navigator.connect initiated channel.

Issue 812853002: Basic tests for sending messages over a navigator.connect initiated channel. (Closed)

Created:
6 years ago by Marijn Kruisselbrink

Modified:
5 years, 11 months ago

Reviewers:
miket_OOO, Jeffrey Yasskin

CC:
blink-reviews

Base URL:
https://chromium.googlesource.com/chromium/blink.git@navigator-connect_connect-tests

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Basic tests for sending messages over a navigator.connect initiated channel. Tests for more complicate cases (including cases such as when the service worker is not running) will be added later. BUG=426458 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187580

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 10

Patch Set 4 : address Jeffrey's comments #

Total comments: 3

Patch Set 5 : fix #

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+195 lines, -71 lines)			Patch
M	LayoutTests/http/tests/navigatorconnect/connect-cross-origin.html	View	1	1 chunk	+2 lines, -29 lines	0 comments	Download
M	LayoutTests/http/tests/navigatorconnect/connect-from-worker.html	View	1	1 chunk	+2 lines, -26 lines	0 comments	Download
A +	LayoutTests/http/tests/navigatorconnect/postmessage.html	View	1 2 3 4	1 chunk	+4 lines, -4 lines	0 comments	Download
A +	LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html	View	1 2 3 4	1 chunk	+8 lines, -6 lines	0 comments	Download
A +	LayoutTests/http/tests/navigatorconnect/postmessage-from-worker.html	View	1 2 3 4	1 chunk	+7 lines, -6 lines	0 comments	Download
A	LayoutTests/http/tests/navigatorconnect/resources/echo-worker.js	View		1 chunk	+10 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js	View	1 2 3	1 chunk	+104 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/navigatorconnect/resources/reply-client-info-worker.js	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
A	LayoutTests/http/tests/navigatorconnect/resources/test-helpers.js	View	1 2 3 4	1 chunk	+47 lines, -0 lines	0 comments	Download

Messages

Total messages: 15 (6 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

miket_OOO

LGTM with nits https://codereview.chromium.org/812853002/diff/60001/LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html File LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html (right): https://codereview.chromium.org/812853002/diff/60001/LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html#newcode19 LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html:19: </body> </html> https://codereview.chromium.org/812853002/diff/60001/LayoutTests/http/tests/navigatorconnect/postmessage-from-worker.html File LayoutTests/http/tests/navigatorconnect/postmessage-from-worker.html (right): ...

6 years ago (2014-12-20 00:00:18 UTC) #3

Marijn Kruisselbrink

https://codereview.chromium.org/812853002/diff/60001/LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html File LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html (right): https://codereview.chromium.org/812853002/diff/60001/LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html#newcode19 LayoutTests/http/tests/navigatorconnect/postmessage-cross-origin.html:19: </body> On 2014/12/20 00:00:18, miket_OOO wrote: > </html> <html> ...

6 years ago (2014-12-20 00:10:32 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812853002/60001

6 years ago (2014-12-20 00:18:19 UTC) #6

Jeffrey Yasskin

https://codereview.chromium.org/812853002/diff/60001/LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js File LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js (right): https://codereview.chromium.org/812853002/diff/60001/LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js#newcode58 LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js:58: channel.port1.postMessage('hello world'); I'd be happier with a more unique ...

6 years ago (2014-12-20 00:31:51 UTC) #8

Jeffrey Yasskin

lgtm https://codereview.chromium.org/812853002/diff/80001/LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js File LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js (right): https://codereview.chromium.org/812853002/diff/80001/LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js#newcode10 LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js:10: function wait_for_reply(t, port) { camelCase is actually more ...

6 years ago (2014-12-20 01:10:20 UTC) #10

Marijn Kruisselbrink

6 years ago (2014-12-20 02:06:16 UTC) #11

Jeffrey Yasskin

https://codereview.chromium.org/812853002/diff/80001/LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js File LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js (right): https://codereview.chromium.org/812853002/diff/80001/LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js#newcode10 LayoutTests/http/tests/navigatorconnect/resources/postmessage-tests.js:10: function wait_for_reply(t, port) { On 2014/12/20 02:06:15, Marijn Kruisselbrink ...

6 years ago (2014-12-20 02:27:35 UTC) #12

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812853002/100001

6 years ago (2014-12-20 02:54:23 UTC) #14

commit-bot: I haz the power

6 years ago (2014-12-20 03:32:19 UTC) #15

Message was sent while issue was closed.

Committed patchset #5 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187580

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages