chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc - Issue 812823002: Remove dependency of infobars component on the embedder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc

Issue 812823002: Remove dependency of infobars component on the embedder (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix compilation on Android Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_navigation_observer.cc ('k') | chrome/browser/ui/android/infobars/confirm_infobar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc

diff --git a/chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc b/chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc

index ad395cef32b824775dc44c3fb5495165780980d9..e3686d7dc383bc0c615cb4b86295a389c5504c3f 100644

--- a/chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc

+++ b/chrome/browser/ui/android/content_settings/popup_blocked_infobar_delegate.cc

@@ -23,12 +23,12 @@ void PopupBlockedInfoBarDelegate::Create(content::WebContents* web_contents,

const GURL& url = web_contents->GetURL();

Profile* profile =

Profile::FromBrowserContext(web_contents->GetBrowserContext());

- scoped_ptr<infobars::InfoBar> infobar(ConfirmInfoBarDelegate::CreateInfoBar(

+ InfoBarService* infobar_service =

+ InfoBarService::FromWebContents(web_contents);

+ scoped_ptr<infobars::InfoBar> infobar(infobar_service->CreateConfirmInfoBar(

scoped_ptr<ConfirmInfoBarDelegate>(new PopupBlockedInfoBarDelegate(

num_popups, url, profile->GetHostContentSettingsMap()))));

- InfoBarService* infobar_service =

- InfoBarService::FromWebContents(web_contents);

// See if there is an existing popup infobar already.

// TODO(dfalcantara) When triggering more than one popup the infobar

// will be shown once, then hide then be shown again.