Remove dependency of infobars component on the embedder

chrome/browser/infobars/infobar_service.h

Index: chrome/browser/infobars/infobar_service.h
diff --git a/chrome/browser/infobars/infobar_service.h b/chrome/browser/infobars/infobar_service.h
index 985b7c0a4dbc1dc49750fec14dcda08b837188b9..89e94dbef15163a0d1b0b1e60d8d954662534258 100644
--- a/chrome/browser/infobars/infobar_service.h
+++ b/chrome/browser/infobars/infobar_service.h
@@ -45,19 +45,24 @@ class InfoBarService : public infobars::InfoBarManager,
   // changes.
   void set_ignore_next_reload() { ignore_next_reload_ = true; }
 
- private:
-  friend class content::WebContentsUserData<InfoBarService>;
-
-  explicit InfoBarService(content::WebContents* web_contents);
-  ~InfoBarService() override;
-
   // InfoBarManager:

[Peter Kasting, 2014/12/19 23:06:23]

Why make these public instead of private?

Normally I try to default to "as private as possible" for overriding
implementations.

Same comment on the protected methods below.

[sdefresne, 2014/12/20 11:30:55]

I need to make CreateConfirmInfoBar() public since most of the client code have
InfoBarService* and not infobars::InfoBarManager*. If the method is private in
InfoBarService* then they cannot call it.

I considered leaving the method private and changing all the client code to use
infobars::InfoBarManager* instead but this made the CL even larger. For the
moment, I'll only leave CreateConfirmInfoBar() public, with a comment to turn it
back private once all client code has been fixed.

[Peter Kasting, 2014/12/22 19:22:05]

It may not be good to make all clients use an InfoBarManager*.  I suspect some
of them on the chrome side need to call InfoBarService-only methods.

If that's not true then maybe the conversion you propose would work.

In any case, that explains making CreateConfirmInfoBar() protected, but not the
other methods.

   int GetActiveEntryID() override;
+  scoped_ptr<infobars::InfoBar> CreateConfirmInfoBar(
+      scoped_ptr<ConfirmInfoBarDelegate> delegate) override;
+
+ protected:
+  // InfoBarManager:
   // TODO(droger): Remove these functions once infobar notifications are
   // removed. See http://crbug.com/354380
   void NotifyInfoBarAdded(infobars::InfoBar* infobar) override;
   void NotifyInfoBarRemoved(infobars::InfoBar* infobar, bool animate) override;
 
+ private:
+  friend class content::WebContentsUserData<InfoBarService>;
+
+  explicit InfoBarService(content::WebContents* web_contents);
+  ~InfoBarService() override;
+
   // content::WebContentsObserver:
   void RenderProcessGone(base::TerminationStatus status) override;
   void DidStartNavigationToPendingEntry(