Remove dependency of infobars component on the embedder

chrome/browser/net/spdyproxy/data_reduction_proxy_infobar_delegate.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_INFOBAR_DELEGATE_H_
 #define CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_INFOBAR_DELEGATE_H_
 
 #include "base/basictypes.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/infobars/core/confirm_infobar_delegate.h"
 #include "components/infobars/core/infobar_delegate.h"
 
 namespace content {
 class WebContents;
 }
 
+namespace infobars {
+class InfoBarManager;
+}

[Peter Kasting, 2014/12/19 23:06:23]

This forward-decl doesn't seem to be needed?

[sdefresne, 2014/12/20 11:30:55]

It is in fact required to allow Android code to provide a system specific
implementation of DataReductionProxyInfoBarDelegate::CreateInfoBar().

[Peter Kasting, 2014/12/22 19:22:05]

I don't understand why the forward-decl is needed in this file, though.  Isn't
it sufficient to declare or define this type in the file that declares/defines
this CreateInfoBar() override?

Basically, I'm just saying that this type is never referred to in this specific
.h, so presumably it could be defined in whatever file #includes this header and
needs it.

[sdefresne, 2014/12/22 20:48:41]

Sorry, I was again unclear. I planned to remove this, but then I found that
compilation failed on Android. This is because the class define a static method
CreateInfoBar() that is overridden in
chrome/browser/ui/android/infobars/data_reduction_proxy_infobar.cc. In a later
patch for this CL, I did have to re-introduce this forward-declaration as I
changed the declaration of CreateInfoBar() to take both an
infobars::InfoBarManager* and a scoped_ptr<DataReductionProxyInfoBarDelegate>.

See patchset 11 where the declaration of CreateInfoBar is slightly different and
uses infobars::InfoBarManager.

+
 // Configures an InfoBar with no buttons that stays visible until it is
 // explicitly dismissed. This InfoBar is suitable for displaying a message
 // and a link, and is used only by an Android field trial.
 class DataReductionProxyInfoBarDelegate : public ConfirmInfoBarDelegate {
  public:
   // Creates the InfoBar and adds it to the provided |web_contents|.
   static void Create(content::WebContents* web_contents,
                      const std::string& link_url);
 
   ~DataReductionProxyInfoBarDelegate() override;
 
  private:
   explicit DataReductionProxyInfoBarDelegate(const std::string& link_url);
 
-  // Returns a Data Reduction Proxy infobar that owns |delegate|.
-  static scoped_ptr<infobars::InfoBar> CreateInfoBar(
-      scoped_ptr<DataReductionProxyInfoBarDelegate> delegate);
-
   // ConfirmInfoBarDelegate
   base::string16 GetMessageText() const override;
   int GetButtons() const override;
   bool ShouldExpire(const NavigationDetails& details) const override;
   bool LinkClicked(WindowOpenDisposition disposition) override;
 
   std::string link_url_;
 
   DISALLOW_COPY_AND_ASSIGN(DataReductionProxyInfoBarDelegate);
 };
 
 #endif  // CHROME_BROWSER_NET_SPDYPROXY_DATA_REDUCTION_PROXY_INFOBAR_DELEGATE_H_