Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: ui/views/controls/webview/web_dialog_view.cc

Issue 812763003: Fix browser launch on the login screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unused parameters. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/webview/web_dialog_view.cc
diff --git a/ui/views/controls/webview/web_dialog_view.cc b/ui/views/controls/webview/web_dialog_view.cc
index ffb5cbafbde128a55ae95a110b54ea67a4f4ee3d..3875cad0251f6be559be539260f29a12438b8d4b 100644
--- a/ui/views/controls/webview/web_dialog_view.cc
+++ b/ui/views/controls/webview/web_dialog_view.cc
@@ -331,6 +331,21 @@ void WebDialogView::BeforeUnloadFired(content::WebContents* tab,
*proceed_to_fire_unload = proceed;
}
+bool WebDialogView::ShouldCreateWebContents(
+ content::WebContents* web_contents,
+ int route_id,
+ int main_frame_route_id,
+ WindowContainerType window_container_type,
+ const base::string16& frame_name,
+ const GURL& target_url,
+ const std::string& partition_id,
+ content::SessionStorageNamespace* session_storage_namespace) {
+ if (delegate_ && !delegate_->HandleShouldCreateWebContents()) {
+ return false;
+ }
+ return true;
+}
sadrul 2015/02/03 02:45:21 return delegate_ ? delegate_->HandleShouldCreateWe
Ivan Podogov 2015/02/03 08:09:08 I'm really into ternary operations as well, althou
+
////////////////////////////////////////////////////////////////////////////////
// WebDialogView, private:

Powered by Google App Engine
This is Rietveld 408576698