Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: ui/web_dialogs/web_dialog_delegate.h

Issue 812763003: Fix browser launch on the login screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Block new window popups on login screen. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/web_dialogs/web_dialog_delegate.h
diff --git a/ui/web_dialogs/web_dialog_delegate.h b/ui/web_dialogs/web_dialog_delegate.h
index ccfd26ef98287f8e292653cf30d97d2d59d672b5..b1fb3afdd17b2f785bb9640e2c831bd9b8b76667 100644
--- a/ui/web_dialogs/web_dialog_delegate.h
+++ b/ui/web_dialogs/web_dialog_delegate.h
@@ -9,6 +9,7 @@
#include <vector>
#include "base/strings/string16.h"
+#include "content/public/browser/web_contents_delegate.h"
#include "ui/base/ui_base_types.h"
#include "ui/base/window_open_disposition.h"
#include "ui/web_dialogs/web_dialogs_export.h"
@@ -128,6 +129,18 @@ class WEB_DIALOGS_EXPORT WebDialogDelegate {
const gfx::Rect& initial_pos,
bool user_gesture);
+ // A callback to control whether a WebContents will be created. Returns
+ // false to disallow the creation. Return true to use the default handler.
+ virtual bool HandleShouldCreateWebContents(
dzhioev (left Google) 2014/12/22 18:30:13 I don't think we need to pass all the arguments of
Ivan Podogov 2014/12/23 06:54:51 True, but I'm not sure if it is a good idea to lea
dzhioev (left Google) 2014/12/23 14:34:25 Let's drop all of them. It is not hard to add para
Ivan Podogov 2014/12/23 14:41:37 Done.
+ content::WebContents* web_contents,
+ int route_id,
+ int main_frame_route_id,
+ WindowContainerType window_container_type,
+ const base::string16& frame_name,
+ const GURL& target_url,
+ const std::string& partition_id,
+ content::SessionStorageNamespace* session_storage_namespace);
+
// Stores the dialog bounds.
virtual void StoreDialogSize(const gfx::Size& dialog_size) {}

Powered by Google App Engine
This is Rietveld 408576698