Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(942)

Unified Diff: ui/views/controls/webview/web_dialog_view.cc

Issue 812763003: Fix browser launch on the login screen. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Block new window popups on login screen. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/views/controls/webview/web_dialog_view.cc
diff --git a/ui/views/controls/webview/web_dialog_view.cc b/ui/views/controls/webview/web_dialog_view.cc
index ffb5cbafbde128a55ae95a110b54ea67a4f4ee3d..2ff00cac3e6870287dc6441c0182bcfbad9aaa44 100644
--- a/ui/views/controls/webview/web_dialog_view.cc
+++ b/ui/views/controls/webview/web_dialog_view.cc
@@ -331,6 +331,23 @@ void WebDialogView::BeforeUnloadFired(content::WebContents* tab,
*proceed_to_fire_unload = proceed;
}
+bool WebDialogView::ShouldCreateWebContents(
+ content::WebContents* web_contents,
+ int route_id,
+ int main_frame_route_id,
+ WindowContainerType window_container_type,
+ const base::string16& frame_name,
+ const GURL& target_url,
+ const std::string& partition_id,
+ content::SessionStorageNamespace* session_storage_namespace) {
+ if (delegate_ && !delegate_->HandleShouldCreateWebContents(
+ web_contents, route_id, main_frame_route_id, window_container_type,
+ frame_name, target_url, partition_id, session_storage_namespace)) {
+ return false;
+ }
+ return true;
+}
+
////////////////////////////////////////////////////////////////////////////////
// WebDialogView, private:

Powered by Google App Engine
This is Rietveld 408576698