Fix browser launch on the login screen.

chrome/browser/chromeos/login/ui/login_web_dialog.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/ui/login_web_dialog.h"
 
 #include <deque>
 
 #include "base/lazy_instance.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/chromeos/login/helper.h"
 #include "chrome/browser/ui/browser_dialogs.h"
+#include "chrome/browser/ui/browser_finder.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/web_contents.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/gfx/geometry/size.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/widget/widget.h"
 
 using content::WebContents;
@@ skipping 127 matching lines @@
 bool LoginWebDialog::ShouldShowDialogTitle() const {
   return true;
 }
 
 bool LoginWebDialog::HandleContextMenu(
     const content::ContextMenuParams& params) {
   // Disable context menu.
   return true;
 }
 
+bool LoginWebDialog::HandleOpenURLFromTab(
+    content::WebContents* source,
+    const content::OpenURLParams& params,
+    content::WebContents** out_new_contents) {
+  // On a login screen, if a missing extension is trying to show in a web
+  // dialog, a NetErrorHelper is displayed instead (hence we have a |source|),
+  // but there is no browser window associated with it. A helper screen will
+  // fire an auto-reload, which in turn leads to opening a new browser window,
+  // so we must suppress it.
+  // http://crbug.com/443096
+  return (source && !chrome::FindBrowserWithWebContents(source));
+}
+
+bool LoginWebDialog::HandleShouldCreateWebContents() {
+  return false;
+}
+
 void LoginWebDialog::Observe(int type,
                              const content::NotificationSource& source,
                              const content::NotificationDetails& details) {
   DCHECK(type == content::NOTIFICATION_LOAD_COMPLETED_MAIN_FRAME);
   // TODO(saintlou): Do we need a throbber for Aura?
   NOTIMPLEMENTED();
 }
 
 }  // namespace chromeos