Removing the |MemoryPressureObserverChromeOS::MemoryPressureLevel| enum.

Removing the |MemoryPressureObserverChromeOS::MemoryPressureLevel| enum.

BUG=-
TEST=-

Committed: https://crrev.com/d6fa29ae5ffe1f9c036dbdeebd887aebbbcb15d8
Cr-Commit-Position: refs/heads/master@{#308815}

[Mr4D (OOO till 08-26), 2014-12-17 00:52:10]

skuhne@chromium.org changed reviewers:
+ mukai@chromium.org

[Mr4D (OOO till 08-26), 2014-12-17 00:52:24]

Can you please have a look at this?

Thanks!

[Mr4D (OOO till 08-26), 2014-12-17 15:00:42]

skuhne@chromium.org changed reviewers:
+ glevin@chromium.org
- mukai@chromium.org

[Mr4D (OOO till 08-26), 2014-12-17 15:01:00]

Please have a look!

[Greg Levin, 2014-12-17 15:07:46]

lgtm

[Mr4D (OOO till 08-26), 2014-12-17 15:07:54]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-12-17 15:08:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812733002/1

[commit-bot: I haz the power, 2014-12-17 15:08:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-17 15:08:11]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[Mr4D (OOO till 08-26), 2014-12-17 15:14:23]

skuhne@chromium.org changed reviewers:
+ rmcilroy@chromium.org
- glevin@chromium.org

[Mr4D (OOO till 08-26), 2014-12-17 15:14:34]

Please have a look!

[rmcilroy, 2014-12-17 15:21:49]

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
File base/chromeos/memory_pressure_observer_chromeos.cc (right):

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
base/chromeos/memory_pressure_observer_chromeos.cc:24: return
MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL;
super nit (ignore if you like) - do this in an "else" block to keep the returns
on the same indentation level.

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
base/chromeos/memory_pressure_observer_chromeos.cc:98: // The
|MemoryPressureListener| does currently not support this.
update comment to state that the MemoryPressureListener does not send a
notification for MEMORY_PRESSURE_LEVEL_NONE

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
base/chromeos/memory_pressure_observer_chromeos.cc:100: case
MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE:
it doesn't seem worth while doing this in a switch when everything should just
fall-through.  Maybe just do:

if (new_pressure == MemoryPressureListener::MEMORY_PRESSURE_LEVEL_NONE) {
   // <comment...>
   return;
}
MemoryPressureListener::NotifyMemoryPressure(new_pressure);

[Mr4D (OOO till 08-26), 2014-12-17 15:28:58]

Please have another look!

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
File base/chromeos/memory_pressure_observer_chromeos.cc (right):

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
base/chromeos/memory_pressure_observer_chromeos.cc:24: return
MemoryPressureListener::MEMORY_PRESSURE_LEVEL_CRITICAL;
On 2014/12/17 15:21:49, rmcilroy wrote:
> super nit (ignore if you like) - do this in an "else" block to keep the
returns
> on the same indentation level.

Done.

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
base/chromeos/memory_pressure_observer_chromeos.cc:98: // The
|MemoryPressureListener| does currently not support this.
On 2014/12/17 15:21:49, rmcilroy wrote:
> update comment to state that the MemoryPressureListener does not send a
> notification for MEMORY_PRESSURE_LEVEL_NONE 

Done.

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
base/chromeos/memory_pressure_observer_chromeos.cc:100: case
MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE:
I did this on purpose since I want to enforce to look at this code when we add
more states. But done.

[rmcilroy, 2014-12-17 15:31:26]

lgtm. thanks.

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
File base/chromeos/memory_pressure_observer_chromeos.cc (right):

https://codereview.chromium.org/812733002/diff/1/base/chromeos/memory_pressur...
base/chromeos/memory_pressure_observer_chromeos.cc:100: case
MemoryPressureListener::MEMORY_PRESSURE_LEVEL_MODERATE:
On 2014/12/17 15:28:58, Mr4D wrote:
> I did this on purpose since I want to enforce to look at this code when we add
> more states. But done.

Agreed that this would be useful but as discussed offline I don't think this is
the right place for it, maybe a unittest instead would work better.

https://codereview.chromium.org/812733002/diff/20001/base/chromeos/memory_pre...
File base/chromeos/memory_pressure_observer_chromeos.cc (right):

https://codereview.chromium.org/812733002/diff/20001/base/chromeos/memory_pre...
base/chromeos/memory_pressure_observer_chromeos.cc:97:
MemoryPressureListener::NotifyMemoryPressure(new_pressure);
nit - I still liked the comment on why we don't send NONE :)

[Mr4D (OOO till 08-26), 2014-12-17 15:36:24]

The CQ bit was checked by skuhne@chromium.org

[commit-bot: I haz the power, 2014-12-17 15:37:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812733002/40001

[commit-bot: I haz the power, 2014-12-17 17:28:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-17 17:29:29]

Patchset 3 (id:??) landed as
https://crrev.com/d6fa29ae5ffe1f9c036dbdeebd887aebbbcb15d8
Cr-Commit-Position: refs/heads/master@{#308815}