Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 812683002: Update mini_chromium to 158694255c7a (Closed)

Created:
6 years ago by Mark Mentovai
Modified:
6 years ago
Reviewers:
scottmg
CC:
crashpad-dev_chromium.org
Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master
Target Ref:
refs/heads/master
Project:
crashpad
Visibility:
Public.

Description

Update mini_chromium to 158694255c7a. This picks up: 158694255c7a win: undef ERROR, causing failing LOGs 3a981db6e6df MSVC: Disable “warning C4702: unreachable code”. e87cd9d4dff5 Tidy string16.h after https://codereview.chromium.org/809563003/ R=scottmg@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/86cf2863502450619d8fbd7e31cb8c898d594a22

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Mark Mentovai
6 years ago (2014-12-16 21:56:46 UTC) #2
scottmg
lgtm
6 years ago (2014-12-16 22:04:40 UTC) #3
Mark Mentovai
6 years ago (2014-12-16 22:12:34 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
86cf2863502450619d8fbd7e31cb8c898d594a22 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698