Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 812673004: Turn off warnings as errors for the debugger (Closed)

Created:
6 years ago by robertphillips
Modified:
6 years ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Turn off warnings as errors for the debugger Compiling the debugger on Linux was running afoul of warnings-as-errors Committed: https://skia.googlesource.com/skia/+/eb3379fe7001932a090e4ed95e0939366813615a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M gyp/debugger.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
robertphillips
6 years ago (2014-12-17 19:07:34 UTC) #2
robertphillips
6 years ago (2014-12-17 19:08:46 UTC) #4
borenet
LGTM
6 years ago (2014-12-17 19:16:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/812673004/1
6 years ago (2014-12-17 19:19:15 UTC) #7
commit-bot: I haz the power
6 years ago (2014-12-17 19:27:53 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/eb3379fe7001932a090e4ed95e0939366813615a

Powered by Google App Engine
This is Rietveld 408576698