bluetooth: BluetoothAdapterDeleter used to control BluetoothAdapter destruction.

bluetooth: BluetoothAdapterDeleter used to control BluetoothAdapter destruction.

BluetoothAdapter must be destroyed on the UI thread (at minimum for the windows
implementation). Until now this was done implicitly. Upcoming use in upcoming
crrev.com/787953004 revealed this. This change explicitly controls the thread
BluetoothAdapter is destroyed on.

BUG=442789
Committed: https://crrev.com/cad5fd77932f1d9fcadbbed1d494ca64f550cf1e
Cr-Commit-Position: refs/heads/master@{#310505}

[scheib, 2014-12-16 21:40:41]

scheib@chromium.org changed reviewers:
+ armansito@chromium.org

[scheib, 2014-12-16 21:47:32]

Patchset #1 (id:1) has been deleted

[armansito, 2014-12-16 22:01:47]

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter.h (left):

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter.h:340: virtual ~BluetoothAdapter();
nit: Empty line after destructor.

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter_chromeos.h (right):

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter_chromeos.h:47: virtual void
DeleteOnCorrectThread() const override;
nit: Drop "virtual" since you already specify "override". The rest of the code
violates this since it hasn't gone through a proper refactor. Let's stick to the
correct style for new code.

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter_mac.h (right):

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter_mac.h:92: virtual void
DeleteOnCorrectThread() const override;
nit: Drop virtual.

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter_win.h (right):

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter_win.h:106: virtual void
DeleteOnCorrectThread() const { delete this; }
Drop virtual, add override. Also, why does this method have a definition? You
added one to bluetooth_adapter_win.cc already.

[scheib, 2014-12-16 22:15:26]

Thanks

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter.h (left):

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter.h:340: virtual ~BluetoothAdapter();
On 2014/12/16 22:01:47, armansito wrote:
> nit: Empty line after destructor.

Done.

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter_chromeos.h (right):

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter_chromeos.h:47: virtual void
DeleteOnCorrectThread() const override;
On 2014/12/16 22:01:47, armansito wrote:
> nit: Drop "virtual" since you already specify "override". The rest of the code
> violates this since it hasn't gone through a proper refactor. Let's stick to
the
> correct style for new code.

Done.

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter_mac.h (right):

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter_mac.h:92: virtual void
DeleteOnCorrectThread() const override;
On 2014/12/16 22:01:47, armansito wrote:
> nit: Drop virtual.

Done.

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
File device/bluetooth/bluetooth_adapter_win.h (right):

https://codereview.chromium.org/812673002/diff/20001/device/bluetooth/bluetoo...
device/bluetooth/bluetooth_adapter_win.h:106: virtual void
DeleteOnCorrectThread() const { delete this; }
On 2014/12/16 22:01:47, armansito wrote:
> Drop virtual, add override. Also, why does this method have a definition? You
> added one to bluetooth_adapter_win.cc already.

Done. Thanks, blatant error.

[armansito, 2014-12-16 22:17:18]

https://codereview.chromium.org/812673002/diff/40001/device/bluetooth/test/mo...
File device/bluetooth/test/mock_bluetooth_adapter.h (right):

https://codereview.chromium.org/812673002/diff/40001/device/bluetooth/test/mo...
device/bluetooth/test/mock_bluetooth_adapter.h:36:
MOCK_METHOD0(DeleteOnCorrectThread, void());
Remove this, now that there's an actual implementation.

[scheib, 2014-12-16 22:28:45]

https://codereview.chromium.org/812673002/diff/40001/device/bluetooth/test/mo...
File device/bluetooth/test/mock_bluetooth_adapter.h (right):

https://codereview.chromium.org/812673002/diff/40001/device/bluetooth/test/mo...
device/bluetooth/test/mock_bluetooth_adapter.h:36:
MOCK_METHOD0(DeleteOnCorrectThread, void());
On 2014/12/16 22:17:18, armansito wrote:
> Remove this, now that there's an actual implementation.

Done.

[armansito, 2014-12-16 22:39:27]

lgtm with nit.

https://codereview.chromium.org/812673002/diff/60001/device/bluetooth/test/mo...
File device/bluetooth/test/mock_bluetooth_adapter.cc (right):

https://codereview.chromium.org/812673002/diff/60001/device/bluetooth/test/mo...
device/bluetooth/test/mock_bluetooth_adapter.cc:17: void
MockBluetoothAdapter::DeleteOnCorrectThread() {
nit: Should be const.

[scheib, 2014-12-17 06:18:38]

Patchset #4 (id:80001) has been deleted

[scheib, 2015-01-08 04:01:26]

Patchset #5 (id:120001) has been deleted

[scheib, 2015-01-08 04:01:37]

Patchset #4 (id:100001) has been deleted

[scheib, 2015-01-08 04:02:08]

Thanks

https://codereview.chromium.org/812673002/diff/60001/device/bluetooth/test/mo...
File device/bluetooth/test/mock_bluetooth_adapter.cc (right):

https://codereview.chromium.org/812673002/diff/60001/device/bluetooth/test/mo...
device/bluetooth/test/mock_bluetooth_adapter.cc:17: void
MockBluetoothAdapter::DeleteOnCorrectThread() {
On 2014/12/16 22:39:27, armansito wrote:
> nit: Should be const.

Done.

[scheib, 2015-01-08 04:02:16]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-08 04:02:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812673002/140001

[commit-bot: I haz the power, 2015-01-08 04:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 04:02:51]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
in order for the CQ to process them

[scheib, 2015-01-08 06:03:54]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-08 06:05:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812673002/140001

[commit-bot: I haz the power, 2015-01-08 06:05:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 06:05:16]

CLs for remote refs other than refs/pending/heads/master must contain NOTRY=true
in order for the CQ to process them

[scheib, 2015-01-08 06:19:58]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-08 06:20:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812673002/160001

[commit-bot: I haz the power, 2015-01-08 08:21:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-08 08:21:20]

Exceeded time limit waiting for builds to trigger.

[scheib, 2015-01-08 14:46:40]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2015-01-08 14:47:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/812673002/160001

[commit-bot: I haz the power, 2015-01-08 15:30:22]

Committed patchset #5 (id:160001)

[commit-bot: I haz the power, 2015-01-08 15:31:12]

Patchset 5 (id:??) landed as
https://crrev.com/cad5fd77932f1d9fcadbbed1d494ca64f550cf1e
Cr-Commit-Position: refs/heads/master@{#310505}