Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: media/media.gyp

Issue 812643005: Re-add AC3/EAC3 audio demuxing support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/media.gyp
diff --git a/media/media.gyp b/media/media.gyp
index 89e1ade22695a566e6b3fe11a4fe4a46eaab32ab..5558c1f893a9bc576112eae94c88a346091feb1c 100644
--- a/media/media.gyp
+++ b/media/media.gyp
@@ -34,8 +34,12 @@
'use_low_memory_buffer%': 0,
}],
['chromecast == 1', {
+ # Enable AC3/EAC3 audio demuxing. Actual decoding must be provided by the
ddorwin 2016/01/08 18:11:02 nit: Regarding line lengths: If it can be done and
servolk 2016/01/08 20:02:32 Done.
+ # platform (or HDMI sink in Chromecast for audio pass-through case).
+ 'enable_ac3_eac3_audio_demuxing%': 1,
'enable_mse_mpeg2ts_stream_parser%': 1,
}, {
+ 'enable_ac3_eac3_audio_demuxing%': 0,
'enable_mse_mpeg2ts_stream_parser%': 0,
}],
['chromecast==1', {
@@ -59,6 +63,7 @@
'variables': {
'buildflag_header_path': 'media/media_features.h',
'buildflag_flags': [
+ "ENABLE_AC3_EAC3_AUDIO_DEMUXING=<(enable_ac3_eac3_audio_demuxing)",
"ENABLE_MSE_MPEG2TS_STREAM_PARSER=<(enable_mse_mpeg2ts_stream_parser)",
],
},

Powered by Google App Engine
This is Rietveld 408576698