Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: media/formats/mp4/es_descriptor.h

Issue 812643005: Re-add AC3/EAC3 audio demuxing support (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/formats/mp4/es_descriptor.h
diff --git a/media/formats/mp4/es_descriptor.h b/media/formats/mp4/es_descriptor.h
index 26ca86db2097f5ae5ff10d303b0acb63b4c9efc0..9066291457bb2c83af38f17076e961c6b65b60e7 100644
--- a/media/formats/mp4/es_descriptor.h
+++ b/media/formats/mp4/es_descriptor.h
@@ -21,8 +21,10 @@ namespace mp4 {
// objectTypeIndication Values. Only values currently in use are included.
enum ObjectType {
kForbidden = 0,
- kISO_14496_3 = 0x40, // MPEG4 AAC
- kISO_13818_7_AAC_LC = 0x67 // MPEG2 AAC-LC
+ kISO_14496_3 = 0x40, // MPEG4 AAC
ddorwin 2016/01/04 23:22:17 Are these complex names the best option? I wonder
servolk 2016/01/07 02:30:04 I don't know. Git blame tells me these were added
+ kISO_13818_7_AAC_LC = 0x67, // MPEG2 AAC-LC
+ kAC3 = 0xa5, // AC3
ddorwin 2016/01/04 23:22:17 Why do the names above have complex names while th
servolk 2016/01/07 02:30:04 I believe the standard that describes AC3/EAC3 aud
ddorwin 2016/01/07 19:12:43 I think we should be consistent, though I'm not wi
+ kEAC3 = 0xa6 // EAC3 / Dolby Digital Plus
};
// This class parse object type and decoder specific information from an

Powered by Google App Engine
This is Rietveld 408576698