Index: content/browser/media/media_canplaytype_browsertest.cc |
diff --git a/content/browser/media/media_canplaytype_browsertest.cc b/content/browser/media/media_canplaytype_browsertest.cc |
index 36254bd352c7111df1fe70b66aa4bd32c0a1b78c..233ffe4e2a629ec0bde256be3ae1454f30adaf06 100644 |
--- a/content/browser/media/media_canplaytype_browsertest.cc |
+++ b/content/browser/media/media_canplaytype_browsertest.cc |
@@ -53,6 +53,12 @@ const char* kMp2tsMaybe = kNot; |
const char* kMp2tsProbably = kNot; |
#endif |
+#if defined(ENABLE_AC3_EAC3_AUDIO_DEMUXING) |
+const char* kAc3Eac3Probably = kPropProbably; |
+#else |
+const char* kAc3Eac3Probably = kNot; |
+#endif |
+ |
namespace content { |
class MediaCanPlayTypeTest : public MediaBrowserTest { |
@@ -217,6 +223,19 @@ class MediaCanPlayTypeTest : public MediaBrowserTest { |
EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"avc3x\"'")); |
EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"mp4ax\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"ac-\"'")); |
ddorwin
2015/11/25 22:24:07
ac
ec
ac3
ec3
servolk
2015/12/03 00:56:14
Done.
|
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"ec-\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"ac-2\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"ec-2\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"ac-4\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"ec-4\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"mp4a.a4\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"mp4a.a7\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"mp4a.a5.\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"mp4a.a6.\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"mp4a.a5.1\"'")); |
+ EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"mp4a.a6.1\"'")); |
+ |
EXPECT_EQ(kNot, CanPlay("'" + mime + "; codecs=\"unknown\"'")); |
// Don't allow incomplete/ambiguous codec ids for HEVC. |
@@ -593,6 +612,31 @@ IN_PROC_BROWSER_TEST_F(MediaCanPlayTypeTest, CodecSupportTest_mp4) { |
EXPECT_EQ(kPropProbably, |
CanPlay("'video/mp4; codecs=\"avc3.42E01E, mp4a.40.29\"'")); |
+ // AC3 and EAC3 (aka Dolby Digital Plus, DD+) audio codecs. |
+ // TODO(servolk): Strictly speaking only mp4a.A5 and mp4a.A6 codec ids are |
+ // valid according to RFC 6381 section 3.3, 3.4. Lower-case oti (mp4a.a5 and |
+ // mp4a.a6) should be rejected. But we used to allow those in older versions |
+ // of Chromecast firmware and some apps (notably MPL) depend on those codec |
+ // types being supported, so they should be allowed for now. |
ddorwin
2015/11/25 22:24:07
bug reference?
servolk
2015/12/03 00:56:14
Done.
|
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'video/mp4; codecs=\"ac-3\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'video/mp4; codecs=\"mp4a.a5\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'video/mp4; codecs=\"mp4a.A5\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'video/mp4; codecs=\"ec-3\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'video/mp4; codecs=\"mp4a.a6\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'video/mp4; codecs=\"mp4a.A6\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, |
+ CanPlay("'video/mp4; codecs=\"avc1.640028,ac-3\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, |
+ CanPlay("'video/mp4; codecs=\"avc1.640028,mp4a.a5\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, |
+ CanPlay("'video/mp4; codecs=\"avc1.640028,mp4a.A5\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, |
+ CanPlay("'video/mp4; codecs=\"avc1.640028,ec-3\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, |
+ CanPlay("'video/mp4; codecs=\"avc1.640028,mp4a.a6\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, |
+ CanPlay("'video/mp4; codecs=\"avc1.640028,mp4a.A6\"'")); |
+ |
EXPECT_EQ(kPropMaybe, CanPlay("'video/mp4; codecs=\"avc1, mp4a.40.2\"'")); |
EXPECT_EQ(kPropMaybe, CanPlay("'video/mp4; codecs=\"avc1, mp4a.40.02\"'")); |
EXPECT_EQ(kPropMaybe, CanPlay("'video/mp4; codecs=\"avc3, mp4a.40.2\"'")); |
@@ -691,6 +735,13 @@ IN_PROC_BROWSER_TEST_F(MediaCanPlayTypeTest, CodecSupportTest_mp4) { |
EXPECT_EQ(kNot, CanPlay("'audio/mp4; codecs=\"hev1.1.6.L93.B0,mp4a.40.5\"'")); |
EXPECT_EQ(kNot, CanPlay("'audio/mp4; codecs=\"hvc1.1.6.L93.B0,mp4a.40.5\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'audio/mp4; codecs=\"ac-3\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'audio/mp4; codecs=\"mp4a.a5\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'audio/mp4; codecs=\"mp4a.A5\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'audio/mp4; codecs=\"ec-3\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'audio/mp4; codecs=\"mp4a.a6\"'")); |
+ EXPECT_EQ(kAc3Eac3Probably, CanPlay("'audio/mp4; codecs=\"mp4a.A6\"'")); |
+ |
TestMPEGUnacceptableCombinations("audio/mp4"); |
EXPECT_EQ(kPropMaybe, CanPlay("'audio/x-m4a'")); |