Re-add AC3/EAC3 audio demuxing support

content/browser/media/media_canplaytype_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "content/browser/media/media_browsertest.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/content_browser_test_utils.h"
 #include "content/shell/browser/shell.h"
@@ skipping 1023 matching lines @@
   EXPECT_EQ(maybeCanPlayHLS,
       CanPlay("'application/vnd.apple.mpegurl; "
               "codecs=\"avc1.42E01E, mp4a.40\"'"));
   EXPECT_EQ(maybeCanPlayHLS,
       CanPlay("'application/vnd.apple.mpegurl; "
               "codecs=\"avc3.42E01E, mp4a.40\"'"));
 
   TestMPEGUnacceptableCombinations("application/vnd.apple.mpegurl");
 }
 
+#if defined(ENABLE_AC3_EAC3_DEMUXING)

[ddorwin, 2015/02/27 01:44:13]

We should always run the tests, but the expected results should be based on this
define.

[servolk, 2015/02/27 02:19:07]

Done.

+IN_PROC_BROWSER_TEST_F(MediaCanPlayTypeTest, CodecSupportTest_ac3_eac3) {
+  // AC3
+  EXPECT_EQ(kPropProbably, CanPlay("'audio/mp4; codecs=\"ac-3\"'"));

[ddorwin, 2015/02/27 01:44:13]

Please also test invalid variants, such as:
ac-2
ac-4
mp4a.a5.
mp4a.a5.1
mp4a.a7

If you put these in TestMPEGUnacceptableCombinations(), they'll run for all
relevant containers.

[servolk, 2015/02/27 02:19:07]

Ok, I've added a few variants, should be enough for basic coverage.

+  EXPECT_EQ(kPropProbably, CanPlay("'audio/mp4; codecs=\"mp4a.a5\"'"));
+  EXPECT_EQ(kPropProbably, CanPlay("'video/mp4; codecs=\"ac-3\"'"));
+  EXPECT_EQ(kPropProbably, CanPlay("'video/mp4; codecs=\"mp4a.a5\"'"));
+  // EAC3 aka DD+ aka Dolby Digital Plus
+  EXPECT_EQ(kPropProbably, CanPlay("'audio/mp4; codecs=\"ec-3\"'"));
+  EXPECT_EQ(kPropProbably, CanPlay("'audio/mp4; codecs=\"mp4a.a6\"'"));
+  EXPECT_EQ(kPropProbably, CanPlay("'video/mp4; codecs=\"ec-3\"'"));
+  EXPECT_EQ(kPropProbably, CanPlay("'video/mp4; codecs=\"mp4a.a6\"'"));

[ddorwin, 2015/02/27 01:44:13]

There are many more test scenarios. For example, x-m4a, HLS, etc. Please inline
these like the others. (By ifdef'ing the result, you won't need ifdefs
everywhere.)

[servolk, 2015/02/27 02:19:07]

What do you mean? I've basically taken one of the existing tests and changed it
to test ac3/eac3 codec variants.

[ddorwin, 2015/03/02 19:35:38]

The tests are broken up by container, not codec. If you add these ~10 lines to
each of the BMFF containers (video/mp4, x-m4a, HLS, etc.) you'll get more
complete coverage (and possibly see that you are enabling things you didn't
intend to). We also need to check that WebM does not support these codecs.

+}
+#endif
+}
+
 }  // namespace content